⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 271895 in webkit


Ignore:
Timestamp:
Jan 26, 2021, 12:40:18 PM (6 years ago)
Author:
Brent Fulgham
Message:

REGRESSION(r261238): WKWebView crashes on launch inside a quicklook preview
​https://bugs.webkit.org/show_bug.cgi?id=219632
<rdar://problem/72154830>

Reviewed by Alexey Proskuryakov.

Partially revert r261238 to allow applications without access to 'nsurlsessiond' to still
be able to use WebKit for local file access. This workaround should be removed once we
complete the work needed to support true offline WebKit use.

  • Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::checkEntitlements): Add an early return if the application
possesses the 'com.apple.security.network.client' entitlement.

Location:
trunk/Source/WebKit
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r271894 r271895  
     12021-01-26  Brent Fulgham  <bfulgham@apple.com>
     2
     3        REGRESSION(r261238): WKWebView crashes on launch inside a quicklook preview
     4        https://bugs.webkit.org/show_bug.cgi?id=219632
     5        <rdar://problem/72154830>
     6
     7        Reviewed by Alexey Proskuryakov.
     8
     9        Partially revert r261238 to allow applications without access to 'nsurlsessiond' to still
     10        be able to use WebKit for local file access. This workaround should be removed once we
     11        complete the work needed to support true offline WebKit use.
     12
     13        * Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm:
     14        (WebKit::XPCServiceInitializerDelegate::checkEntitlements): Add an early return if the application
     15        possesses the 'com.apple.security.network.client' entitlement.
     16
    1172021-01-26  Per Arne  <pvollan@apple.com>
    218

  • trunk/Source/WebKit/Shared/EntryPointUtilities/Cocoa/XPCService/XPCServiceEntryPoint.mm

    r269908 r271895  
    4444#if PLATFORM(MAC) || PLATFORM(MACCATALYST)
    4545    if (isClientSandboxed()) {
     46        // FIXME(<rdar://problem/54178641>): Remove this check once WebKit can work without network access.
     47        if (hasEntitlement("com.apple.security.network.client"))
     48            return true;
     49
    4650        audit_token_t auditToken = { };
    4751        xpc_connection_get_audit_token(m_connection.get(), &auditToken);
Note: See TracChangeset for help on using the changeset viewer.