From aba7bfec92069e0a8db89fa9abf14006f4f221e8 Mon Sep 17 00:00:00 2001 From: Jorge Esteban Quilcate Otoya Date: Thu, 5 Nov 2026 12:36:39 +0200 Subject: [PATCH] fix(inkless:build): omit commitId in make build_release outside git Outside a git checkout, `git rev-parse HEAD` printed nothing, so the Makefile passed an empty `-PcommitId=`. `determineCommitId()` saw the property and used the empty value as the commit id. Pass `-PcommitId` only when `git rev-parse HEAD` succeeds. Otherwise Gradle falls back to "unknown". Assisted-by: Claude Sonnet 5.5 --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 66fdcd7301..8e43ec34d0 100644 --- a/Makefile +++ b/Makefile @@ -33,7 +33,7 @@ build_all: core/build/distributions/kafka_2.13-$(VERSION).tgz: echo "Building Kafka distribution with version $(VERSION)" - ./gradlew releaseTarGz -PcommitId=$$(git rev-parse HEAD) + ./gradlew releaseTarGz $$(commit=$$(git rev-parse HEAD 2>/dev/null) && echo "-PcommitId=$$commit") .PHONY: build_release build_release: core/build/distributions/kafka_2.13-$(VERSION).tgz