grep: default to posix digits with -P #1631
Open
+78
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change -P so it will by default only include the ASCII digits when \d is used in a expresion, as it performs better and it is what the user wanter (most likely).
For consistency also do the same for [:digit:] and make sure this way that the recommendation for Unicode handling of Regex (TR18) is followed more closely (considering that both \d and [:digit:] match the POSIX definition of digits)