From bbfc43725f7706b05744ee8d0f42378ea3251fea Mon Sep 17 00:00:00 2001 From: bryan Date: Tue, 28 Jul 2026 09:57:38 -0700 Subject: [PATCH] chore: scrub private-repo references ahead of open-sourcing MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Removes links to private trackers (inbox, infra) from a script and a doc comment — including one in a runtime CI error annotation that would print the URL into public logs. The factual observations (the #869 hang timing, the arm64 dispatch bug) are kept; only the private references are dropped. #869 stays as a same-repo reference. Co-Authored-By: Claude Fable 5 --- crates/decode/src/builds.rs | 4 ++-- scripts/bulk-upload-e2e.sh | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/decode/src/builds.rs b/crates/decode/src/builds.rs index d3064022a..70e327361 100644 --- a/crates/decode/src/builds.rs +++ b/crates/decode/src/builds.rs @@ -701,8 +701,8 @@ pub struct BuildDecl { /// `None` means the build-decl did not explicitly declare a target and should /// be hydrated with the target of whatever graph is being constructed from it. /// This happens at the decode→graph seam in `graph::BuildSpec::from_decoded`, - /// which consults `Loader::for_target`. See gominimal/infra#18 for the arm64 - /// res-server dispatch bug that motivated moving this from eager to deferred. + /// which consults `Loader::for_target`. Moved from eager to deferred to fix + /// an arm64 dispatch bug where the target was resolved before it was known. pub target: Option, /// Any attributes explicitly set on this build-decl. pub attrs: Option>, diff --git a/scripts/bulk-upload-e2e.sh b/scripts/bulk-upload-e2e.sh index 0894aa7f0..3a6812f31 100755 --- a/scripts/bulk-upload-e2e.sh +++ b/scripts/bulk-upload-e2e.sh @@ -49,7 +49,7 @@ # rate to 50%. Any single failure fails the whole run. # # #869 also sometimes HANGS the client outright rather than erroring -# (https://github.com/gominimal/inbox/issues/335, observed at 9 and 13 minutes), +# (observed at 9 and 13 minutes), # so every activate runs under a wall-clock deadline and a hang counts as a # failure. A hang also stops the loop — five deadlines back to back would burn # the nightly's whole job budget, and one is already conclusive. @@ -327,7 +327,7 @@ for i in $(seq 1 "$ITER"); do # the run, and folding them into a collapsed group buries them. echo "::endgroup::" if [ "$rc" -eq 124 ]; then - echo "::error::iteration $i: 'min activate' still running after ${DEADLINE_SECS}s — the #869 hang (https://github.com/gominimal/inbox/issues/335)" + echo "::error::iteration $i: 'min activate' still running after ${DEADLINE_SECS}s — the #869 hang" elif [ "$rc" -eq 0 ]; then echo "::error::iteration $i: activate's last stdout line is not a session UUID: '$sid'" else