Add quality scale for GIOS #155603
Draft
Add quality scale for GIOS #155603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This was referenced Nov 1, 2025
bieniu
requested changes
Nov 1, 2025
| appropriate-polling: done | ||
| brands: done | ||
| common-modules: done | ||
| config-flow-test-coverage: done |
Member
There was a problem hiding this comment.
Suggested change
| config-flow-test-coverage: done | |
| config-flow-test-coverage: | |
| status: todo | |
| comment: Config flow tests should end with `CREATE_ENTRY` or `ABORT`. |
Comment on lines
+5
to
+6
| comment: | | ||
| No custom actions are defined. |
Member
There was a problem hiding this comment.
Suggested change
| comment: | | |
| No custom actions are defined. | |
| comment: No custom actions are defined. |
Comment on lines
+15
to
+16
| comment: | | ||
| No custom actions are defined. |
Member
There was a problem hiding this comment.
Suggested change
| comment: | | |
| No custom actions are defined. | |
| comment: No custom actions are defined. |
Comment on lines
+31
to
+32
| comment: | | ||
| No custom actions are defined. |
Member
There was a problem hiding this comment.
Suggested change
| comment: | | |
| No custom actions are defined. | |
| comment: No custom actions are defined. |
Comment on lines
+42
to
+43
| comment: | | ||
| This integration does not require authentication. |
Member
There was a problem hiding this comment.
Suggested change
| comment: | | |
| This integration does not require authentication. | |
| comment: This integration does not require authentication. |
| status: exempt | ||
| comment: | | ||
| This integration does not require authentication. | ||
| test-coverage: done |
Member
There was a problem hiding this comment.
Suggested change
| test-coverage: done | |
| test-coverage: | |
| status: todo | |
| comment: Mock the entire Gios object instead of the method. |
Comment on lines
+50
to
+51
| comment: | | ||
| This integration is a cloud service and thus does not support discovery. |
Member
There was a problem hiding this comment.
Suggested change
| comment: | | |
| This integration is a cloud service and thus does not support discovery. | |
| comment: This integration is a cloud service and thus does not support discovery. |
Comment on lines
+54
to
+55
| comment: | | ||
| This integration is a cloud service and thus does not support discovery. |
Member
There was a problem hiding this comment.
Suggested change
| comment: | | |
| This integration is a cloud service and thus does not support discovery. | |
| comment: This integration is a cloud service and thus does not support discovery. |
Comment on lines
+61
to
+62
| comment: | | ||
| This is an service, which doesn't integrate with any devices. |
Member
There was a problem hiding this comment.
Suggested change
| comment: | | |
| This is an service, which doesn't integrate with any devices. | |
| comment: This is an service, which doesn't integrate with any devices. |
| entity-device-class: done | ||
| entity-disabled-by-default: done | ||
| entity-translations: done | ||
| exception-translations: todo |
Member
There was a problem hiding this comment.
Suggested change
| exception-translations: todo | |
| exception-translations: done |
b28204b to
d16d33c
Compare
21 tasks
mik-laj
commented
Nov 3, 2025
| entity-translations: done | ||
| exception-translations: todo | ||
| icon-translations: done | ||
| reconfiguration-flow: |
Contributor
Author
There was a problem hiding this comment.
We have two parameters - Name and Station ID, but I prepared a PR that removes Name field. See: #155741
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all.To help with the load of incoming pull requests: