Use Null Coalescing Assignment Operator #1995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maks-rafalko
approved these changes
Jul 14, 2024
Member
maks-rafalko
left a comment
There was a problem hiding this comment.
up to you: does it make sense to create an issue in rector/php-cs-fixer to support properties? or is there any issue, probably you already found?
theofidry
approved these changes
Jul 15, 2024
Member
Author
I didn't find any solution yet.
That was my plan to create an issue in Rector. |
Member
Author
|
thanks @maks-rafalko, @theofidry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't bring a big value it just replacing
$variable ?? $variable = $this->dosmth()with Null Coalescing Assignment Operator$variable ??= $this->dosmth()Unfortunately there is no any rule nor in Rector or PHP-CS-Fixer which may cover such cases and fail builds in the future.
Existing in both projects doesn't take into account properties.
PHP-CS-Fixer: https://cs.symfony.com/doc/rules/operator/assign_null_coalescing_to_coalesce_equal.html
Rector: https://github.com/rectorphp/rector/blob/main/rules/Php74/Rector/Assign/NullCoalescingOperatorRector.php