From c96346413c713731b1472f5fef592382a4efbc63 Mon Sep 17 00:00:00 2001 From: jesko Date: Mon, 24 Nov 2025 13:53:07 +0100 Subject: [PATCH 1/2] removes incorrect duplicate parsing of TimeDateStamp --- minidump/header.py | 1 - 1 file changed, 1 deletion(-) diff --git a/minidump/header.py b/minidump/header.py index 032e089..b291c6a 100644 --- a/minidump/header.py +++ b/minidump/header.py @@ -39,7 +39,6 @@ def parse(buff): mh.NumberOfStreams = int.from_bytes(buff.read(4), byteorder = 'little', signed = False) mh.StreamDirectoryRva = int.from_bytes(buff.read(4), byteorder = 'little', signed = False) mh.CheckSum = int.from_bytes(buff.read(4), byteorder = 'little', signed = False) - mh.Reserved = int.from_bytes(buff.read(4), byteorder = 'little', signed = False) mh.TimeDateStamp = int.from_bytes(buff.read(4), byteorder = 'little', signed = False) try: mh.Flags = MINIDUMP_TYPE(int.from_bytes(buff.read(4), byteorder = 'little', signed = False)) From 039f4673ab5ca59193e54ba8a87f371f17653450 Mon Sep 17 00:00:00 2001 From: jesko Date: Mon, 24 Nov 2025 13:59:25 +0100 Subject: [PATCH 2/2] removes remaining references to Reserved field --- minidump/header.py | 3 --- minidump/writer.py | 1 - 2 files changed, 4 deletions(-) diff --git a/minidump/header.py b/minidump/header.py index b291c6a..7c7a822 100644 --- a/minidump/header.py +++ b/minidump/header.py @@ -11,7 +11,6 @@ def __init__(self): self.NumberOfStreams:int = None self.StreamDirectoryRva:int = None self.CheckSum:int = 0 - self.Reserved:int = 0 self.TimeDateStamp:int = 0 self.Flags:MINIDUMP_TYPE = None @@ -22,7 +21,6 @@ def to_bytes(self): t += self.NumberOfStreams.to_bytes(4, byteorder = 'little', signed = False) t += self.StreamDirectoryRva.to_bytes(4, byteorder = 'little', signed = False) t += self.CheckSum.to_bytes(4, byteorder = 'little', signed = False) - t += self.Reserved.to_bytes(4, byteorder = 'little', signed = False) t += self.TimeDateStamp.to_bytes(4, byteorder = 'little', signed = False) t += self.Flags.value.to_bytes(4, byteorder = 'little', signed = False) @@ -61,7 +59,6 @@ def __str__(self): t+= 'NumberOfStreams: %s\n' % self.NumberOfStreams t+= 'StreamDirectoryRva: %s\n' % self.StreamDirectoryRva t+= 'CheckSum: %s\n' % self.CheckSum - t+= 'Reserved: %s\n' % self.Reserved t+= 'TimeDateStamp: %s\n' % self.TimeDateStamp t+= 'Flags: %s\n' % self.Flags return t \ No newline at end of file diff --git a/minidump/writer.py b/minidump/writer.py index b8038ae..04bd29c 100644 --- a/minidump/writer.py +++ b/minidump/writer.py @@ -204,7 +204,6 @@ def prepare_header(self): self.header.NumberOfStreams = len(self.streams) +1 # +1 is fot he memory info stream self.header.StreamDirectoryRva = self.directory_rva #self.header.CheckSum = None - #self.header.Reserved = None #self.header.TimeDateStamp = None self.header.Flags = MINIDUMP_TYPE.MiniDumpWithFullMemory self.header_buffer.write(self.header.to_bytes())