From 38d9f8acf7e79bced3523315bf32662700491bc6 Mon Sep 17 00:00:00 2001 From: Alex Kubacki Date: Wed, 15 Jul 2026 12:06:34 -0600 Subject: [PATCH 1/2] ACM requires a positive serial --- lib/mini_ca/certificate.rb | 3 ++- lib/mini_ca/version.rb | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/mini_ca/certificate.rb b/lib/mini_ca/certificate.rb index a851c58..7c013a5 100644 --- a/lib/mini_ca/certificate.rb +++ b/lib/mini_ca/certificate.rb @@ -26,7 +26,8 @@ def initialize( @counter = 0 x509.version = 0x2 - x509.serial = serial || 0 + # https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.2 — must be unique positive integer + x509.serial = serial || OpenSSL::BN.rand(128, 0) x509.public_key = public_key diff --git a/lib/mini_ca/version.rb b/lib/mini_ca/version.rb index 3e6c417..8f14c68 100644 --- a/lib/mini_ca/version.rb +++ b/lib/mini_ca/version.rb @@ -1,3 +1,3 @@ module MiniCa - VERSION = '1.2.1'.freeze + VERSION = '1.2.2'.freeze end From 2473997149905e08f03e216beba62271bb5a14e0 Mon Sep 17 00:00:00 2001 From: Alex Kubacki Date: Wed, 15 Jul 2026 12:22:21 -0600 Subject: [PATCH 2/2] lint --- lib/mini_ca/certificate.rb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/mini_ca/certificate.rb b/lib/mini_ca/certificate.rb index 7c013a5..1ad1989 100644 --- a/lib/mini_ca/certificate.rb +++ b/lib/mini_ca/certificate.rb @@ -26,7 +26,8 @@ def initialize( @counter = 0 x509.version = 0x2 - # https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.2 — must be unique positive integer + # https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.2 + # must be unique positive integer x509.serial = serial || OpenSSL::BN.rand(128, 0) x509.public_key = public_key