Attachment 474332 Details for Bug 588403

[patch] Part 2. Ignore popup child widgets when updating.

ignorepopups (text/plain), 1.45 KB, created by Timothy Nikkel (:tnikkel)

(hide)

Description:

Filename:

MIME Type:

Creator: Timothy Nikkel (:tnikkel)

Size: 1.45 KB

patch

obsolete

># HG changeset patch
># Parent 63d97d1b512ae6e3e9330fe77b52ce9367683dbb
># User Timothy Nikkel <tnikkel@gmail.com>
>Bug 588403. Part 2. Don't remove the area of popup widgets from the area to update on the parent widget.
>
>diff --git a/view/src/nsViewManager.cpp b/view/src/nsViewManager.cpp
>--- a/view/src/nsViewManager.cpp
>+++ b/view/src/nsViewManager.cpp
>@@ -604,17 +604,20 @@ nsViewManager::UpdateWidgetArea(nsView *
>   if (aWidget->GetTransparencyMode() != eTransparencyTransparent) {
>     for (nsIWidget* childWidget = aWidget->GetFirstChild();
>          childWidget;
>          childWidget = childWidget->GetNextSibling()) {
>       nsView* view = nsView::GetViewFor(childWidget);
>       NS_ASSERTION(view != aWidgetView, "will recur infinitely");
>       PRBool visible;
>       childWidget->IsVisible(visible);
>-      if (view && visible && !IsWidgetDrawnByPlugin(childWidget, view)) {
>+      nsWindowType type;
>+      childWidget->GetWindowType(type);
>+      if (view && visible && !IsWidgetDrawnByPlugin(childWidget, view) &&
>+          type != eWindowType_popup) {
>         // Don't mess with views that are in completely different view
>         // manager trees
>         nsViewManager* viewManager = view->GetViewManager();
>         if (viewManager->RootViewManager() == RootViewManager()) {
>           // get the damage region into view's coordinate system and appunits
>           nsRegion damage =
>             ConvertRegionBetweenViews(intersection, aWidgetView, view);
>

Flags:

roc: review+

Actions: View | Diff | Review

Attachments on bug 588403: 470196 | 470345 | 472956 | 474244 | 474246 | 474247 | 474332