Attachment 515799 Details for Bug 580531

[patch] Patch: Handle multiple frames per chunk per packet in WebM playback statistics.

580531-webmreader-chunking.patch (text/plain), 1.13 KB, created by Chris Pearce [:cpearce (Not reading bugmail)]

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Pearce [:cpearce (Not reading bugmail)]

Size: 1.13 KB

patch

obsolete

># HG changeset patch
># User Chris Pearce <chris@pearce.org.nz>
># Parent ec7089f436abc01e54e4e85e1fe856dc86ce1f82
>Bug 580531 - Handle multiple frames per chunk per packet in WebM playback statistics. r=kinetik
>
>diff --git a/content/media/webm/nsWebMReader.cpp b/content/media/webm/nsWebMReader.cpp
>--- a/content/media/webm/nsWebMReader.cpp
>+++ b/content/media/webm/nsWebMReader.cpp
>@@ -678,20 +678,20 @@ PRBool nsWebMReader::DecodeVideoFrame(PR
>     if (r == -1) {
>       return PR_FALSE;
>     }
> 
>     vpx_codec_stream_info_t si;
>     memset(&si, 0, sizeof(si));
>     si.sz = sizeof(si);
>     vpx_codec_peek_stream_info(&vpx_codec_vp8_dx_algo, data, length, &si);
>-    if ((aKeyframeSkip && !si.is_kf) || (aKeyframeSkip && si.is_kf && tstamp_ms < aTimeThreshold)) {
>-      aKeyframeSkip = PR_TRUE;
>+    if (aKeyframeSkip && (!si.is_kf || tstamp_ms < aTimeThreshold)) {
>+      // Skipping to next keyframe...
>       parsed++; // Assume 1 frame per chunk.
>-      break;
>+      continue;
>     }
> 
>     if (aKeyframeSkip && si.is_kf) {
>       aKeyframeSkip = PR_FALSE;
>     }
> 
>     if (vpx_codec_decode(&mVP8, data, length, NULL, 0)) {
>       return PR_FALSE;

Flags:

cpearce: review+

Actions: View | Diff | Review

Attachments on bug 580531: 458935 | 458937 | 465555 | 465556 | 468611 | 468612 | 468617 | 495942 | 496253 | 496254 | 496258 | 514667 | 515506 | 515799 | 516082 | 516083 | 516105 | 516139 | 516418 | 516419