Attachment #8833634 for bug #1330006

Attachment #8833634: Self-hosting eslint plugin for bug #1330006

View | Details | Raw Unified | Return to bug 1330006
Collapse All | Expand All





embedding/**
extensions/**
gfx/**
gradle/**
hal/**
image/**
intl/**
ipc/**
js/**
layout/**
media/**
memory/**
mfbt/**
modules/**
mozglue/**
netwerk/**
nsprpub/**

devtools/client/debugger/test/mochitest/code_math.min.js
devtools/client/debugger/test/mochitest/code_math_bogus_map.js
devtools/client/debugger/test/mochitest/code_ugly*
devtools/client/debugger/test/mochitest/code_worker-source-map.js
devtools/client/framework/test/code_ugly*
devtools/server/tests/unit/babel_and_browserify_script_with_source_map.js
devtools/server/tests/unit/setBreakpoint*

# Exclude everything but selfhosted JS
js/ductwork/**
js/examples/**
js/ipc/**
js/public/**
js/xpconnect/**
js/src/jit-tests/**
js/src/tests/**

# mobile/android/ exclusions
mobile/android/tests/

# Uses `#filter substitution`
mobile/android/b2gdroid/app/b2gdroid.js
mobile/android/app/mobile.js
mobile/android/chrome/content/healthreport-prefs.js


-      Line
+  Link Here
-      Line 0
+  Link Here
+"use strict";
+module.exports = {
+  "extends": [
+    "../../../toolkit/.eslintrc.js"
+  ],
+  "rules": {
+    // We should fix those at some point, but we use this to detect NaNs.
+    "no-self-compare": "off",
+    // Disabling these two make it easier to implement the spec.
+    "spaced-comment": "off",
+    "no-lonely-if": "off",
+    // SpiderMonkey's style doesn't match any of the possible options.
+    "brace-style": "off",
+    // Manually defining all the selfhosted methods is a slog.
+    "no-undef": "off",
+    // Disabled until we can use let/const to fix those erorrs.
+    "no-redeclare": "off",
+  }
+};






//------------------------------------------------------------------------------
// Plugin Definition
//------------------------------------------------------------------------------

module.exports = {
  processors: {
    ".xml": require("../lib/processors/xbl-bindings"),
    ".js": require("../lib/processors/self-hosted"),
  },
  rules: {
    "avoid-removeChild": require("../lib/rules/avoid-removeChild"),
    "balanced-listeners": require("../lib/rules/balanced-listeners"),
    "import-browserjs-globals": require("../lib/rules/import-browserjs-globals"),
    "import-globals": require("../lib/rules/import-globals"),
    "import-headjs-globals": require("../lib/rules/import-headjs-globals"),
    "import-test-globals": require("../lib/rules/import-test-globals"),

-      Line
+  Link Here
-      Line 0
+  Link Here
+/**
+ * @fileoverview Remove macros from SpiderMonkey's self-hosted JS.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+"use strict";
+const selfHostedRegex = /js\/src\/builtin\/.*?\.js$/;
+const macroRegex = /\s*\#(if|ifdef|else|elif|endif|include|define|undef).*/;
+module.exports = {
+  preprocess: function(text, filename) {
+    if (!selfHostedRegex.test(filename)) {
+      return [text];
+    }
+    let lines = text.split(/\n/);
+    for (let i = 0; i < lines.length; i++) {
+      if (!macroRegex.test(lines[i])) {
+        // No macro here, nothing to do.
+        continue;
+      }
+      for (; i < lines.length; i++) {
+        lines[i] = "// " + lines[i];
+        // If the line ends with a backslash (\), the next line
+        // is also part of part of the macro.
+        if (!lines[i].endsWith("\\")) {
+          break;
+        }
+      }
+    }
+    return [lines.join("\n")];
+  },
+  postprocess: function(messages, filename) {
+    let errors = [];
+    for (let i = 0; i < messages.length; i++) {
+      for (let message of messages[i]) {
+        errors.push(message);
+      }
+    }
+    return errors;
+  }
+}

(-)a/tools/lint/eslint/eslint-plugin-mozilla/package.json (-1 / +1 lines)

Line	Link Here

Lines 1-11	Link Here

  "name": "eslint-plugin-mozilla",

  "name": "eslint-plugin-mozilla",

  "version": "0.2.17",

  "version": "0.2.18",

  "description": "A collection of rules that help enforce JavaScript coding standard in the Mozilla project.",

  "description": "A collection of rules that help enforce JavaScript coding standard in the Mozilla project.",

  "keywords": [

  "keywords": [

    "eslint",

    "eslint",

    "eslintplugin",

    "eslintplugin",

    "eslint-plugin",

    "eslint-plugin",

    "mozilla",

    "mozilla",

    "firefox"

    "firefox"

],

],

Return to bug 1330006