Attachment 130172 Details for Bug 130078

[patch] Untested patch

patch (text/plain), 2.49 KB, created by Robert O'Callahan (:roc) (email my personal email if necessary)

(hide)

Description:

Filename:

MIME Type:

Creator: Robert O'Callahan (:roc) (email my personal email if necessary)

Size: 2.49 KB

patch

obsolete

>Index: content/base/src/nsDocumentViewer.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/content/base/src/nsDocumentViewer.cpp,v
>retrieving revision 1.338
>diff -u -t -p -6 -r1.338 nsDocumentViewer.cpp
>--- content/base/src/nsDocumentViewer.cpp	6 Aug 2003 03:06:43 -0000	1.338
>+++ content/base/src/nsDocumentViewer.cpp	21 Aug 2003 13:48:07 -0000
>@@ -1810,48 +1810,12 @@ DocumentViewerImpl::MakeWindow(nsIWidget
> 
>     if (data) {
>       CallQueryInterface(data, &containerView);
>     }
>   }
> 
>-  if (containerView) {
>-    // see if the containerView has already been hooked into a foreign view manager hierarchy
>-    // if it has, then we have to hook into the hierarchy too otherwise bad things will happen.
>-    nsIViewManager* containerVM = containerView->GetViewManager();
>-    nsIView* pView = containerView;
>-    do {
>-      pView = pView->GetParent();
>-    } while (pView && pView->GetViewManager() == containerVM);
>-
>-    if (!pView) {
>-      // OK, so the container is not already hooked up into a foreign view manager hierarchy.
>-      // That means we can choose not to hook ourselves up.
>-      //
>-      // If the parent container is a chrome shell, or a frameset, then we won't hook into its view
>-      // tree. This will improve performance a little bit (especially given scrolling/painting perf bugs)
>-      // but is really just for peace of mind. This check can be removed if we want to support fancy
>-      // chrome effects like transparent controls floating over content, transparent Web browsers, and
>-      // things like that, and the perf bugs are fixed.
>-      nsCOMPtr<nsIDocShellTreeItem> container(do_QueryInterface(mContainer));
>-      nsCOMPtr<nsIDocShellTreeItem> parentContainer;
>-      PRInt32 itemType;
>-      if (nsnull == container
>-          || NS_FAILED(container->GetParent(getter_AddRefs(parentContainer)))
>-          || nsnull == parentContainer
>-          || NS_FAILED(parentContainer->GetItemType(&itemType))
>-          || itemType != nsIDocShellTreeItem::typeContent) {
>-        containerView = nsnull;
>-      } else {
>-        nsCOMPtr<nsIWebShell> webShell(do_QueryInterface(parentContainer));
>-        if (nsnull == webShell || IsWebShellAFrameSet(webShell)) {
>-          containerView = nsnull;
>-        }
>-      }
>-    }
>-  }
>-
>   rv = view->Init(mViewManager, tbounds, containerView);
>   if (NS_FAILED(rv))
>     return rv;
> 
>   nsCOMPtr<nsIDocShellTreeItem> treeItem(do_QueryInterface(mContainer));
>   NS_ENSURE_TRUE(treeItem, NS_ERROR_FAILURE);

Actions: View | Diff | Review

Attachments on bug 130078: 130172 | 191565 | 206053 | 209787 | 220348 | 220737 | 241004 | 260724 | 260725 | 285010 | 285029 | 425945 | 425946 | 427177 | 449631 | 449633 | 453999 | 454424 | 454426 | 455299 | 462530 | 464587 | 465752 | 467516 | 468409