Attachment 217775 Details for Bug 333312

[patch] patch

333312.diff (text/plain), 1.31 KB, created by :Gavin Sharp [email: gavin@gavinsharp.com]

(hide)

Description:

Filename:

MIME Type:

Creator: :Gavin Sharp [email: gavin@gavinsharp.com]

Size: 1.31 KB

patch

obsolete

>Index: xpfe/components/directory/nsDirectoryViewer.cpp
>===================================================================
>RCS file: /cvsroot/mozilla/xpfe/components/directory/nsDirectoryViewer.cpp,v
>retrieving revision 1.123
>diff -u -p -8 -r1.123 nsDirectoryViewer.cpp
>--- xpfe/components/directory/nsDirectoryViewer.cpp	30 Mar 2006 21:06:48 -0000	1.123
>+++ xpfe/components/directory/nsDirectoryViewer.cpp	9 Apr 2006 17:59:25 -0000
>@@ -185,21 +185,21 @@ nsHTTPIndex::OnFTPControlLog(PRBool serv
>     nsCOMPtr<nsIScriptGlobalObject> scriptGlobal(do_GetInterface(mRequestor));
>     NS_ENSURE_TRUE(scriptGlobal, NS_OK);
> 
>     nsIScriptContext *context = scriptGlobal->GetContext();
>     NS_ENSURE_TRUE(context, NS_OK);
> 
>     JSContext* jscontext = NS_REINTERPRET_CAST(JSContext*,
>                                                context->GetNativeContext());
>+    NS_ENSURE_TRUE(jscontext, NS_OK);
> 
>     JSObject* global = JS_GetGlobalObject(jscontext);
>+    NS_ENSURE_TRUE(global, NS_OK);
> 
>-    if (!jscontext || !global) return NS_OK;
>-    
>     jsval params[2];
> 
>     nsString unicodeMsg;
>     unicodeMsg.AssignWithConversion(msg);
>     JSString* jsMsgStr = JS_NewUCStringCopyZ(jscontext, (jschar*) unicodeMsg.get());
> 
>     params[0] = BOOLEAN_TO_JSVAL(server);
>     params[1] = STRING_TO_JSVAL(jsMsgStr);

Flags:

timeless: review+
jag+mozilla: superreview+
neil: approval-branch-1.8.1+

Actions: View | Diff | Review

Attachments on bug 333312: 217775