226793 unknown 2003-11-25 18:14:18 -0800 Setting/getting last mod time differs on some systems 2013-01-18 08:39:30 -0800 1 1 3 Components Core XPCOM Trunk x86 Windows 2000 defect RESOLVED DUPLICATE 377307 [M1] P3 normal --- 1 ben.bucksch nobody cbiesinger doug.turner wtc --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- 2013-01-17 16:39:58 --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- --- 2013-01-17 16:39:58 0 2014798 ben.bucksch 2003-11-25 18:14:18 -0800 Reproducability: Unknown. Bug appears on 2 W2K systems in California, but not on my W2K system in Germany. I don't have access to the California systems. Reproduction: 1. W2K, set timezone to PDT winter time (-0800) 2. int t1 = 1066244633000; // == 2003-10-15 21:03:53 nsIFile f = ...; f.lastModifiedFile = t1; int t2 = f.lastModifiedFile; print t2; Actual result: t2 == 1066248233000; // == 2003-10-15 22:03:53 == t1 + 1 hour Expected result: t2 == t1 Analysis: That 1 hour made me suspect a timezone problem, that the impl. of getter and setter differ. In fact, they do, the getter is implemented in NSPR and using a shortcut, the setter is implemented in xpcom/io/ and uses a number of scary local time conversions. 2016140 ben.bucksch 2003-11-27 20:11:09 -0800 Bug appears reproducably on FAT filesystems, but not on NTFS filesystems, to my knowledge. Compare <http://msdn.microsoft.com/library/default.asp?url=/library/en-us/sysinfo/base/setfiletime.asp>: "FAT records times on disk in local time. However, NTFS records times on disk in UTC." 2016147 ben.bucksch 2003-11-27 21:30:40 -0800 No, wrong, can't reproduce on a FAT16 partition, I ran instead into another (documented) problem, the impreciseness of FAT's last mod time. The California systems are FAT32. Will continue to try to reproduce. 2022432 ben.bucksch 2003-12-08 03:13:48 -0800 Bug appears, if the "Adjust for daylight saving time" setting of the OS is checked. Both on NTFS and FAT. Cases to be considered: (any combination of) - "Daylight saving time adjustment" on or off - File time in during daylight saving time or winter time - File time set during daylight saving time or winter time - File time read during daylight saving time or winter time - File time read by Mozilla (NSPR) or Explorer - File time set by Mozilla (XPCOM) or Windows (edit file with Notepad) - NTFS or FAT = 64 cases I didn't have time to cover them all. Despite some quite scary code in NSPR (hardcoded offset; direct reading of FILETIME strcture, although discouraged by MS), and a seemingly wrong call to LocalFileTimeToFileTime(), the main culprit seems to be the PR_LocalTimeParameters parameter to PR_ExplodeTime in XPCOM IO. Windows System time is in UTC, so converting our NSPR time into local time and feeding that to Windows System Time functions will give wrong results. Changing that parameter to PR_GMTParameters seems to fix the bug. But I also removed the LocalFileTimeToFileTime() call, to make the code match MS's example code and because it didn't make sense to me. Strangely, it doesn't seem to make a difference for the correctness of the result, in my testings. Attaching fix against Mozilla 1.4.1. Use |patch -p 0| to apply. 2022437 137040 ben.bucksch 2003-12-08 03:20:37 -0800 Created attachment 137040 Proposed fix, version 1. > = 64 cases eh, 128 :). 2022560 137040 doug.turner 2003-12-08 08:21:14 -0800 Comment on attachment 137040 Proposed fix, version 1. wtc needs to review this. 2159290 ben.bucksch 2004-05-25 01:18:36 -0700 no answer from wtc. dougt, what do we do? 2171923 137040 wtc 2004-06-10 14:23:38 -0700 Comment on attachment 137040 Proposed fix, version 1. r=wtc. The fix is correct. The comment change to nsprpub/pr/src/md/windows/w95io.c can be omitted. The new comment for xpcom/io/nsLocalFileWin.cpp can also be omitted. It is useful for reviewing this change, but it won't really help understand the new code. The new code is straightforward and easy to understand. By the way, in xpcom/io/nsLocalFileWin.cpp I am wondering if we should pass NULL as the third argument to SetFileTime because we should not modify the last access time. 2288449 ben.bucksch 2004-10-09 10:49:44 -0700 shaver? 2324921 doug.turner 2004-11-10 17:49:35 -0800 nsLocalFileWin.cpp has changed since this patch was created. Specifically in version 1.125. Ben, can check out these changes and create a new diff. 2384577 137040 doug.turner 2005-01-12 16:52:01 -0800 Comment on attachment 137040 Proposed fix, version 1. ben, can you provide a new patch? 7012451 benjamin 2013-01-17 08:39:58 -0800 *** This bug has been marked as a duplicate of bug 377307 *** 7016747 ben.bucksch 2013-01-18 08:34:09 -0800 Funny. The patch commited in bug 377307 in 2011 is - apart from comments and bitrot - *exactly* the same that I submitted here in 2003, 7 years earlier. The review here took 1 year (!), and by that time it had bitrotted and I had moved on to other projects. 7016770 ben.bucksch 2013-01-18 08:39:30 -0800 (And I found it unbelievably sarcastic to wait with the review so long that the patch bitrots, and then deny the review *because of* this bitrot and ask more work from the contributor.) 137040 2003-12-08 03:20:37 -0800 2005-01-12 16:52:01 -0800 Proposed fix, version 1. 226793-1.diff text/plain 2785 ben.bucksch ZGlmZiAtdSB7YXJjaH0vKytwcmlzdGluZS10cmVlcy91bmxvY2tlZC9tYW55b25lL21hbnlvbmUt LWJldGEvbWFueW9uZS0tYmV0YS0tMS4xL2luZm9AYmVvbmV4LmNvbS0tbW96aWxsYS10bGEvbWFu eW9uZS0tYmV0YS0tMS4xLS1wYXRjaC01Ny9uc3BycHViL3ByL3NyYy9tZC93aW5kb3dzL3c5NWlv LmMgbnNwcnB1Yi9wci9zcmMvbWQvd2luZG93cy93OTVpby5jCi0tLSB7YXJjaH0vKytwcmlzdGlu ZS10cmVlcy91bmxvY2tlZC9tYW55b25lL21hbnlvbmUtLWJldGEvbWFueW9uZS0tYmV0YS0tMS4x L2luZm9AYmVvbmV4LmNvbS0tbW96aWxsYS10bGEvbWFueW9uZS0tYmV0YS0tMS4xLS1wYXRjaC01 Ny9uc3BycHViL3ByL3NyYy9tZC93aW5kb3dzL3c5NWlvLmMJMjAwMy0xMS0yNiAwMjozODoyMi4w MDAwMDAwMDAgKzAxMDAKKysrIG5zcHJwdWIvcHIvc3JjL21kL3dpbmRvd3Mvdzk1aW8uYwkyMDAz LTEyLTA4IDEyOjExOjQxLjAwMDAwMDAwMCArMDEwMApAQCAtOTMsNiArOTMsNyBAQAogCiAjaWZk ZWYgREVCVUcKICAgICAvKiBEb3VibGVjaGVjayBfcHJfZmlsZXRpbWVfb2Zmc2V0J3MgaGFyZC1j b2RlZCB2YWx1ZSBpcyBjb3JyZWN0LiAqLworICAgIC8qIENvbXBhcmUgX1BSX0ZpbGVUaW1lVG9Q UlRpbWUgKi8KICAgICB7CiAgICAgICAgIFNZU1RFTVRJTUUgc3lzdGltZTsKICAgICAgICAgdW5p b24gewpAQCAtNTkyLDYgKzU5MywxMSBAQAogCiAjaWZkZWYgREVCVUcKICAgICAvKiBEb3VibGVj aGVjayBvdXIgY2FsY3VsYXRpb24uICovCisgICAgLyogQ29tcGFyZQorICAgICAgIDxodHRwOi8v bXNkbi5taWNyb3NvZnQuY29tL2xpYnJhcnkvZGVmYXVsdC5hc3A/dXJsPS9saWJyYXJ5L2VuLXVz L3N5c2luZm8vYmFzZS9yZXRyaWV2aW5nX3RoZV9sYXN0X3dyaXRlX3RpbWUuYXNwPgorICAgICAg IChleGFtcGxlIGNvZGUpIGFuZAorICAgICAgIHhwY29tL2lvL25zTG9jYWxGaWxlV2luLmNwcDo6 U2V0TW9kRGF0ZSAob3RoZXIgd2F5IGFyb3VuZCkKKyAgICAgICBhbmQgdGhpcyBmaWxlOjpfUFJf TURfSU5JVF9JTygpIChvdGhlciBjaGVjaykgKi8KICAgICB7CiAgICAgICAgIFNZU1RFTVRJTUUg c3lzdGltZTsKICAgICAgICAgUFJFeHBsb2RlZFRpbWUgZXRtOwpkaWZmIC11IHthcmNofS8rK3By aXN0aW5lLXRyZWVzL3VubG9ja2VkL21hbnlvbmUvbWFueW9uZS0tYmV0YS9tYW55b25lLS1iZXRh LS0xLjEvaW5mb0BiZW9uZXguY29tLS1tb3ppbGxhLXRsYS9tYW55b25lLS1iZXRhLS0xLjEtLXBh dGNoLTU3L3hwY29tL2lvL25zTG9jYWxGaWxlV2luLmNwcCB4cGNvbS9pby9uc0xvY2FsRmlsZVdp bi5jcHAKLS0tIHthcmNofS8rK3ByaXN0aW5lLXRyZWVzL3VubG9ja2VkL21hbnlvbmUvbWFueW9u ZS0tYmV0YS9tYW55b25lLS1iZXRhLS0xLjEvaW5mb0BiZW9uZXguY29tLS1tb3ppbGxhLXRsYS9t YW55b25lLS1iZXRhLS0xLjEtLXBhdGNoLTU3L3hwY29tL2lvL25zTG9jYWxGaWxlV2luLmNwcAky MDAzLTExLTI2IDAyOjU5OjI3LjAwMDAwMDAwMCArMDEwMAorKysgeHBjb20vaW8vbnNMb2NhbEZp bGVXaW4uY3BwCTIwMDMtMTItMDggMTI6MTI6MzIuMDAwMDAwMDAwICswMTAwCkBAIC0xNTEyLDEy ICsxNTEyLDEzIEBACiAgICAgICAgIHJldHVybiBDb252ZXJ0V2luRXJyb3IoR2V0TGFzdEVycm9y KCkpOwogICAgIH0KIAotICAgIEZJTEVUSU1FIGxmdCwgZnQ7CisgICAgRklMRVRJTUUgZnQ7CiAg ICAgU1lTVEVNVElNRSBzdDsKICAgICBQUkV4cGxvZGVkVGltZSBwcmV0OwogICAgIAogICAgIC8v IFBSX0V4cGxvZGVUaW1lIGV4cGVjdHMgdXNlY3MuLi4KLSAgICBQUl9FeHBsb2RlVGltZShhTGFz dE1vZGlmaWVkVGltZSAqIFBSX1VTRUNfUEVSX01TRUMsIFBSX0xvY2FsVGltZVBhcmFtZXRlcnMs ICZwcmV0KTsKKyAgICBQUl9FeHBsb2RlVGltZShhTGFzdE1vZGlmaWVkVGltZSAqIFBSX1VTRUNf UEVSX01TRUMsCisgICAgICAgICAgICAgICAgICAgUFJfR01UUGFyYW1ldGVycywgJnByZXQpOwog ICAgIHN0LndZZWFyICAgICAgICAgICAgPSBwcmV0LnRtX3llYXI7ICAgIAogICAgIHN0LndNb250 aCAgICAgICAgICAgPSBwcmV0LnRtX21vbnRoICsgMTsgLy8gQ29udmVydCBzdGFydCBvZmZzZXQg LS0gV2luMzI6IEphbj0xOyBOU1BSOiBKYW49MAogICAgIHN0LndEYXlPZldlZWsgICAgICAgPSBw cmV0LnRtX3dkYXk7ICAgIApAQCAtMTUyNywxMSArMTUyOCwxMiBAQAogICAgIHN0LndTZWNvbmQg ICAgICAgICAgPSBwcmV0LnRtX3NlYzsKICAgICBzdC53TWlsbGlzZWNvbmRzICAgID0gcHJldC50 bV91c2VjLzEwMDA7CiAKLSAgICBpZiAoIDAgPT0gU3lzdGVtVGltZVRvRmlsZVRpbWUoJnN0LCAm bGZ0KSApCi0gICAgewotICAgICAgICBydiA9IENvbnZlcnRXaW5FcnJvcihHZXRMYXN0RXJyb3Io KSk7Ci0gICAgfQotICAgIGVsc2UgaWYgKCAwID09IExvY2FsRmlsZVRpbWVUb0ZpbGVUaW1lKCZs ZnQsICZmdCkgKQorICAgIC8qIENvbXBhcmUKKyAgICAgICA8aHR0cDovL21zZG4ubWljcm9zb2Z0 LmNvbS9saWJyYXJ5L2VuLXVzL3N5c2luZm8vYmFzZS9jaGFuZ2luZ19hX2ZpbGVfdGltZV90b190 aGVfY3VycmVudF90aW1lLmFzcD4KKyAgICAgICAoZXhhbXBsZSBjb2RlKSBhbmQgbnNwcnB1Yi9w ci9zcmMvbWQvd2luZG93cy93OTVpby5jIChvdGhlciB3YXkgYXJvdW5kKQorICAgICovCisKKyAg ICBpZiAoIDAgPT0gU3lzdGVtVGltZVRvRmlsZVRpbWUoJnN0LCAmZnQpICkKICAgICB7CiAgICAg ICAgIHJ2ID0gQ29udmVydFdpbkVycm9yKEdldExhc3RFcnJvcigpKTsKICAgICB9Cg==