Review of "Dhruva" version 3.1 (19)

Details Page Preview

A clean, highly customizable dock for GNOME Shell. Features: • Hover magnification with six motion styles • Window minimize animations • Panel mode that brings the top bar into the dock • Background blur and color themes • App folders, window previews and peek • Running indicators and notification badges • Multi-monitor support on any screen edge • Independent dock with its own pinned apps • Quick Launch with Super + 1–9 • Clock, Trash, drive and folder modules • Music Pill with synced lyrics

Extension Homepage
https://github.com/narkagni/dhruva

No comments.

Diff Against

Files

Note: Binary files aren't shown on the web site. To see all files, please download the extension zipfile.

Shexli (experimental) error 1 warning 1

Shexli found 2 issues that may need reviewer attention.

EGO-X-004 warning

extensions should avoid synchronous file IO in shell code

Shell code should avoid synchronous file IO APIs like `GLib.file_get_contents()` and `Gio.File.load_contents()`.

File Operations

  • src/core/AppManager.js:104
    file.load_contents(null)

EGO-M-004 error

metadata shell-version must only include plausible stable releases and at most one development release

Field `shell-version` contains invalid values, more than one development release, or implausible future releases.

metadata.json must be well-formed

  • metadata.json
    shell-version=['45', '46', '47', '48', '49', '50', '51']

All Versions

Version Status
5.0 (27) Active
4.9 (26) Inactive
4.9 (25) Rejected
4.7 (24) Inactive
4.6 (23) Rejected
4.3 (22) Rejected
4.3 (21) Rejected
4.3 (20) Rejected
3.1 (19) Rejected
3.1 (18) Rejected
2.0 (17) Inactive
1.5 (16) Inactive
1.4 (15) Inactive
1.2 (14) Inactive
1.2 (13) Inactive
1.1 (12) Inactive
11 Inactive
10 Inactive
9 Rejected
8 Rejected
7 Rejected
6 Rejected
5 Rejected
4 Inactive
3 Inactive
2 Rejected
1 Rejected

Previous Reviews on this Version

JustPerfection rejected
1. `this._destroyed` is a bad practice. Please search in the package and remove them. 2. Timeout should be remove on destroy and before creating a new one (line 454, 543 `src/ui/dock/DockRenderer.js`). 3. Is that `|| fName === 'Новая папка'` intentional (line 76 `src/ui/modules/SystemFoldersModule.js`)? 4. You cannot create instance of objects in global scope (line 218 `src/core/SettingsManager.js`). 5. When you return at line 731 `src/ui/modules/music/MusicPillPopup.js`, It means nothing after that is cleanup in racy situations and since that is needed for destroy, it means selective disable.