Skip to content

r.out.ascii: Create an option to write a LISFLOOD compatible header #4695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

r.out.ascii: Create an option to write a LISFLOOD compatible header #4695

wants to merge 19 commits into from

Conversation

YannChemin
Copy link
Contributor

The option applied by the "-l" flag permits to write an ASCII grid file compatible with the European LISFLOOD model (https://ec-jrc.github.io/lisflood-model/1_1_introduction_LISFLOOD/)

@github-actions github-actions bot added raster Related to raster data processing C Related code is in C HTML Related code is in HTML module docs labels Nov 12, 2024
github-actions[bot]
github-actions bot reviewed Nov 13, 2024
View reviewed changes
petrasovaa
petrasovaa requested changes Nov 13, 2024
View reviewed changes
@nilason nilason changed the title Create an option to write a LISFLOOD compatible header r.out.ascii: Create an option to write a LISFLOOD compatible header Nov 22, 2024
echoix
echoix requested changes Feb 26, 2025
View reviewed changes
echoix and others added 2 commits March 19, 2025 18:23
@echoix @github-actions
Apply clang suggestions from code review
3886d58 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@echoix
Merge branch 'main' into main
c0d909b
@echoix
Copy link
Member

echoix commented Mar 19, 2025

For your next PRs, you'll have more luck by not using the main branch of your fork for a PR

YannChemin added 3 commits July 4, 2025 08:23
@YannChemin
Merge branch 'OSGeo:main' into main
506ff14
@YannChemin
Update main.c
6ea4951 
G_option_exclusive(flag.surfer, flag.noheader, NULL);
G_option_exclusive(flag.surfer, flag.modflow, NULL);
G_option_exclusive(flag.surfer, flag.lisflood, NULL);
G_option_exclusive(flag.lisflood, flag.modflow, NULL);
@YannChemin
Update r.out.ascii.md
a83f70b 
updated with Lisflood info
@YannChemin YannChemin requested review from echoix and petrasovaa July 4, 2025 08:44
@github-actions github-actions bot added the markdown Related to markdown, markdown files label Jul 4, 2025
@YannChemin
Copy link
Contributor Author

YannChemin commented Jul 4, 2025 •
edited by echoix
Loading

For your next PRs, you'll have more luck by not using the main branch of your fork for a PR

Do you mean something like that?

git checkout -b something-branch
git add something
git commit -m "that something is changed"
git push -u origin something-branch
gh pr create --base main --head something-branch --fill

@echoix
Copy link
Member

echoix commented Jul 4, 2025

For your next PRs, you'll have more luck by not using the main branch of your fork for a PR

Do you mean something like that?

git checkout -b something-branch
git add something
git commit -m "that something is changed"
git push -u origin something-branch
gh pr create --base main --head something-branch --fill

Yep, seems right

echoix
echoix requested changes Jul 4, 2025
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure changing the relative markdown links from ending with ".md" to ending with ".html" is expected.

echoix
echoix reviewed Jul 4, 2025
View reviewed changes
Copy link
Member

@echoix echoix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other questions on markdown syntax

petrasovaa
petrasovaa reviewed Jul 18, 2025
View reviewed changes
petrasovaa
petrasovaa previously approved these changes Jul 18, 2025
View reviewed changes
petrasovaa
petrasovaa reviewed Jul 21, 2025
View reviewed changes
@YannChemin YannChemin requested a review from echoix July 25, 2025 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@petrasovaa petrasovaa petrasovaa approved these changes

@echoix echoix Awaiting requested review from echoix

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
C Related code is in C docs HTML Related code is in HTML markdown Related to markdown, markdown files module raster Related to raster data processing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@YannChemin @echoix @petrasovaa