Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the fuse daemon process a parent of the payload process rather than a sibling #1287

Open
remleduff opened this issue Oct 13, 2023 · 3 comments
Open

Make the fuse daemon process a parent of the payload process rather than a sibling #1287

remleduff opened this issue Oct 13, 2023 · 3 comments

Comments

@remleduff
Copy link

remleduff commented Oct 13, 2023 •
edited
Loading

Currently running an appimage creates two processes:

  1. The fuse daemon process: <appimage>.appimage
  2. The actual payload process, which can be named anything

My users get confused by this, as they think they should be able to go to "task manager" and kill the process that they just ran. However, this just kills the fuse process, and the application keeps running to some extent. It crashes eventually when the application attempts to read something that wasn't already cached.

To me, it would be clearer in the process list if the fuse daemon process was a true parent of the payload process. Since the child in this case can't work without the parent, it would also be nice if killing the "parent" also killed the "child."

It's perfectly possible I'm misunderstanding something here though.

Thanks for a great software distribution system!
@probonopd
Copy link
Member

Hello @remleduff. Yes, that would be much better. Do you know how to do this in code? A pull request on https://github.com/AppImage/type2-runtime would be highly appreciated.

cc @TheAssassin

@remleduff
Copy link
Author

I'll look into this, I'm interested at least. My thought is to basically switch the code after the fork call, and make the child start the payload, and the parent be the fuse daemon.

@probonopd probonopd changed the title Should the fuse daemon process be a parent of the payload process rather than a sibling? Make the fuse daemon process a parent of the payload process rather than a sibling Nov 1, 2023
@TheAssassin
Copy link
Member

I'd have to have a look myself first to provide any feedback. Feel free to send a PR. I'll have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@remleduff @probonopd @TheAssassin