Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Theme doesn't apply everywhere #165

Closed
Naverene opened this issue Aug 15, 2024 · 5 comments · Fixed by #630
Closed

Global Theme doesn't apply everywhere #165

Naverene opened this issue Aug 15, 2024 · 5 comments · Fixed by #630
Labels
bug Something isn't working

Comments

@Naverene
Copy link

Describe the bug

after applying "Global Dark Theme" KDE Settings is in light mode

To Reproduce

Steps to reproduce the behavior:
open KDE Settings

Expected behavior

KDE Settings to be in dark mode

Screenshots

image

@nnyyxxxx
Copy link
Contributor

nnyyxxxx commented Sep 3, 2024

I'll take a look.

@GreatNovaDragon
Copy link

Paraphrasing from #288

The Global Theme script attempts to put use the qt6-theme controll application as the global QT-Theme (which you do outside of KDE), and in the qt6 controll application, then sets kvantum (an theme-engine) as its theme. Still correct.

Then for kvantum, a non-existent kvantum theme (Breeze) is set, which is the issue. Breeze in itself is the default theme-ing of KDE, which is why it might be sane to assume that this might exist as a kvantum theme. But kvantum is not an official KDE thing, and uses different mechanisms to KDE/QT themeing, so Breeze does NOT support it.

@GreatNovaDragon
Copy link

To be precise, this line is at fault

https://github.com/ChrisTitusTech/linutil/blob/f46d3137b797c22cd917897544c3effde6eeb0cc/core/tabs/system-setup/global-theme.sh#L56C1-L56C13

The solution is to put something else than Breeze there. From the default themes that come with kvantum, i muse kvArc would be the best one.

In the end, its a question of Chris's Preference what theme should be set

@adamperkowski
Copy link
Collaborator

/label 'bug'

@github-actions github-actions bot added the bug Something isn't working label Sep 22, 2024
@nnyyxxxx nnyyxxxx mentioned this issue Sep 22, 2024
4 tasks
@nnyyxxxx
Copy link
Contributor

will be fixed in #630

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants