Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrap start.sh code in curly braces to protect against partial downloads #348

Closed
TigerGorilla2 opened this issue Sep 12, 2024 · 0 comments · Fixed by #388
Closed

Wrap start.sh code in curly braces to protect against partial downloads #348

TigerGorilla2 opened this issue Sep 12, 2024 · 0 comments · Fixed by #388
Labels
bug Something isn't working

Comments

@TigerGorilla2
Copy link

Describe the bug

Don't depend on the user to use the correct flags for curl to protect against partial downloads.
Wrap the start.sh code like this

#!/bin/sh

{ # Prevent execution if this script was only partially downloaded
  # start.sh code
  ...
} # End of wrapping

Additional context

The Nix package manager install script does the same see:
https://nixos.org/nix/install
@TigerGorilla2 TigerGorilla2 added the bug Something isn't working label Sep 12, 2024
@jeevithakannan2 jeevithakannan2 mentioned this issue Sep 15, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Add wrapper around script jeevithakannan2/linutil
1 participant
@TigerGorilla2