[feature] Add Quests by Faction tab #4743
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates to Quest Details Frame
BreakBB
commented
Oct 6, 2023
|
|
||
| local factionGroups = {} | ||
| local factionWithoutId = -1 | ||
| for index=1, GetNumFactions() do -- TODO: Remove this as it limits the Journey to only show known factions to the player |
Comment on lines
+81
to
+82
| -- TODO Loop over factionMap and use GetFactionInfoByID to grab the required translations | ||
| -- TODO Delete all faction translations. We still need the IDs though so maybe keep enUS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue references
Fixes #3344
Proposed changes
Big props to @scleal who developed the base functionality for this in #3419
Screenshots