Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document numeric encoding scheme #459

Open
gkorland opened this issue Aug 23, 2018 · 5 comments
Open

Document numeric encoding scheme #459

gkorland opened this issue Aug 23, 2018 · 5 comments
Assignees
Labels
no-issue-activity x:quality Code-Quality related (performance, test, etc. -not directly affecting functionality)

Comments

@gkorland
Copy link
Contributor

No description provided.

@mnunberg mnunberg self-assigned this Aug 30, 2018
@mnunberg
Copy link
Contributor

@itamarhaber @gkorland @MeirShpilraien @stockholmux The idea here is to take things like NOOFSETS, MAXDOCTABLESIZE and similarly named options, and document them as

MAX_DOCTABLE_SIZE, NO_OFFSETS, and so on. The older names would retain their meaning and validity for people still using the code, but we would no longer document it going forward. This should give us more flexibility in what kinds of options we expose, and actually have people read them correctly.

@stockholmux
Copy link
Contributor

We should probably have a period when both syntaxes/keywords are valid and documented. If someone has an existing code base with the old syntax (maybe only weeks old), it should be somewhere so they aren't left head scratching over the documentation.

@mnunberg
Copy link
Contributor

True, something like:

MAX_DOCTABLE_SIZE (deprecated: MAXDOCTABLESIZE)

@stockholmux
Copy link
Contributor

My 2 cents.

I would probably do something like a general notice at the top of the doc pages that looks something like:

RediSearch is migrating to underscore concatenated keywords. This means that keywords like MAXDOCTABLESIZE will eventually be deprecated in favor of MAX_DOCTABLE_SIZE. This will increase readability.

When mentioning referencing keywords individually MAX_DOCTABLE_SIZE / MAXDOCTABLESIZEevery time. Do this for a release or two then do the MAX_DOCTABLE_SIZE (deprecated: MAXDOCTABLESIZE) thing. Then, finally, just drop MAXDOCTABLESIZE style keywords and put a replace the general notice with one that says we removed these keywords for a few versions, and finally just drop that entirely too.

It's slow and laborious, but probably the safest.

@mnunberg mnunberg added the x:quality Code-Quality related (performance, test, etc. -not directly affecting functionality) label Sep 7, 2018
@github-actions
Copy link

Stale issue message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-issue-activity x:quality Code-Quality related (performance, test, etc. -not directly affecting functionality)
Projects
None yet
Development

No branches or pull requests

3 participants