Replies: 9 comments 22 replies
-
|
This would be wonderful to have in the Sylius core. I would love to help everything I can. So first of all your use case is too simple to actually outline the 'real' difficulties with catalog promotions: Here is a more complex use case:
What are your internal thoughts on this? Is this something you want to handle in the first version of this feature? I have a few ideas on how I wanted to tackle this in my own plugin, but I think it would be great if we handled it in the core if you're up for it :) |
Beta Was this translation helpful? Give feedback.
-
|
And I just want to clarify why I would like to discuss this more complex use case: With your use case it would be sufficient to update the channel pricings (which is what I do in Setonos plugin), but with this more complex use case prices should be output dynamically. |
Beta Was this translation helpful? Give feedback.
-
|
Everything besides timezones we are considering within the first version of this feature :) 💪🏼 |
Beta Was this translation helpful? Give feedback.
-
|
If we want to keep the actual promotion behaviour and just add a new capability :
Or we can imagine a dedicated page in the admin allowing to choose what will be inside this
The rest is an extensive use of the I never used promotions from other products than Sylius so maybe there is better ideas than this one. |
Beta Was this translation helpful? Give feedback.
-
|
As Sylius is becoming rather API-first lately, then I cannot promise we will add this functionality to Sylius, but I have also been thinking about it. Regarding the catalog promotions, I have proposed two fields: label and description. The label is meant to be displayed on/around/near the product's main image - but I am not considering any display method yet, for headless Sylius shops this leaves unlimited options of the display, and the model could be extended with configurable display types. For core Sylius I'd go with one, overridable display type (+docs). The description is designed to be an explanation text, where the Admin could elaborate on how long will the promo be on etc. |
Beta Was this translation helpful? Give feedback.
-
|
Based on the answer from @CoderMaggie here are a few opinions:
With this setup there is still an obstacle: How do we know or how do we decide when to update/assign catalog promotions? If we did it every time a catalog promotions was created it could easily be that it would run 10 times in a row (because the administrator updated/created 10 promos). And what about product changes? The rules would most like be affected by taxon or product changes, so should we also run it each time a product changes? What we do in the catalog promotion plugin is to check |
Beta Was this translation helpful? Give feedback.
-
As someone who has come from the Magento platform, I can say that this method works well. It's a logical separation of promotions that occur within the cart (mostly coupons), and promotions that are shown directly on the product page. |
Beta Was this translation helpful? Give feedback.
-
|
another three cases
|
Beta Was this translation helpful? Give feedback.
-
This is not a catalog promotion and can be done already in Sylius
This doesn't change the implementation, this is just another rule
This is also an order promotion, not a catalog promotion and can be done already |
Beta Was this translation helpful? Give feedback.
-
|
Thank you all very much for your feedback. We are currently considering event-driven architecture to apply catalog promotions, which will be based on Symfony messenger with doctrine transport layer in the standard implementation. We believe that this kind of approach will be the most flexible for our community to replace/extend/change. Let me explain how it could work: Let's break it down into few problems as we did in the previous example: Storing catalog promotion configurationA new entity with all information about rules & actions that will take on the product catalog. Triggering change on the product catalogThe default implementation will be based on delayed messages (This can also be an effortless cron job that will run every 10 minutes. Delayed messages will reduce the number of triggers to check if now is the time to apply promotion). During the creation of the catalog promotion, we will delay a message. In this case, it will be 24h. Start of the promo: End of the promo: ... -> here will be a place to implement messaging optimization algorithms. Like for example, in the case of big catalogs, some chunking mechanism. Regarding customer groups, it is a different type of problem. I am going to open a new discussion about this topic soon, so stay tuned. |
Beta Was this translation helpful? Give feedback.
-
|
Hi, @Arminek Just to clarify your idea. Do you want to force the usage of a doctrine transport to use a database table to hold delayed messages and then have a consumer reading from that table/queue? |
Beta Was this translation helpful? Give feedback.
-
|
@loevgaard We are aiming for September. This is a forecast tho 😄 |
Beta Was this translation helpful? Give feedback.
-
Do all Messenger transports support delayed messages? |
Beta Was this translation helpful? Give feedback.
-
Yes, it's handled by stamps: https://symfony.com/doc/current/messenger.html#envelopes-stamps to be more accurate by |
Beta Was this translation helpful? Give feedback.
-
|
@stloyd: Weird that I haven't noticed that. That's a great feature :D Thank you for enlightening me :) |
Beta Was this translation helpful? Give feedback.
-
|
I am not sure how it will work with InMemoryTransport. For sure, we are going to use it in test env to do not handle time in our test suite 💃 |
Beta Was this translation helpful? Give feedback.
-
|
@loevgaard We have started the first sprint about catalog promotions 🎉 |
Beta Was this translation helpful? Give feedback.
-
|
Cool! Thanks for updating. I appreciate that 😊 |
Beta Was this translation helpful? Give feedback.
-
|
🖖 Hello, We have finished two sprints so far 🎉 . Features that we have covered:
Our next goals:
If you want to help us deliver the best quality you can contribute by testing what we did so far 💃 |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the update, @Arminek! Is the 'scope' somewhat equivalent to the rules in promotions? |
Beta Was this translation helpful? Give feedback.
-
|
@loevgaard What do you mean by equivalent to the rules in promotions? Are you referring to the existing cart promotion engine? |
Beta Was this translation helpful? Give feedback.
-
|
Yes, the existing cart promo engine. I.e. the scope is a set of rules to match variants? |
Beta Was this translation helpful? Give feedback.
-
|
Some of them will be quite similar to the existing promotion engine. But definitely not all of them. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, of course. Thank you :) |
Beta Was this translation helpful? Give feedback.
-
|
🖖 Hello, Features that we have covered:
Our next goals:
Demo I would like to start testing it for big product catalogs. Do you have any SQL to share with a huge amount of products & variants (500k variants)? cc @loevgaard @stloyd @Prometee @Roshyo @vvasiloi |
Beta Was this translation helpful? Give feedback.
-
|
From a recent experience I can say that the performance in this case does not depend on the number of products and variants, but on the amount of promotions and their related resources (like taxons). |
Beta Was this translation helpful? Give feedback.
-
👋 Hello, Sylius community,
In the core team, we were discussing how to tackle catalog promotions. I would like to share our perspective on this topic with you, but before we jump into the proposition, let’s build a shared understanding of the problem.
Here is the story:
As a store owner, I want to make a discount for all products within a taxon by 50% starting 2021-03-21 and ending 2021-12-12
Okay, so let’s break down this case into few problems and possible solutions
This example story is straightforward, and of course, there are more complex cases, but let’s focus on this.
We would be very grateful if you could share any thoughts about this topic. Cheers!
Relates to:
Beta Was this translation helpful? Give feedback.
All reactions