Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split UI code into separate module #20

Open
barryoneill opened this issue Mar 10, 2017 · 5 comments
Open

Split UI code into separate module #20

barryoneill opened this issue Mar 10, 2017 · 5 comments
Assignees

Comments

@barryoneill
Copy link
Collaborator

barryoneill commented Mar 10, 2017

To facilitate cleaner building but also to support switching out alternate UIs (useful for Issue #6) we should split the UI out as a separate module within the holdmail project structure.

  • have ability to build + unit test UI module separate from backend, but
  • maintain ability to build entire application as usual with a single gradle call.
@nateprice
Copy link
Collaborator

I have been writing the react code in a project named holdmail-fontend. We might even want to go as far as holdmail-react-front and holldmail-angular-frontend and holdmail-*-frontend. This would allow a developer to choose which front end they would like to use. The hard part if we add a new feature to one we should update all over them.

@nateprice
Copy link
Collaborator

One issue I ran into was spring boot threw a cors error. You can either annotate the endpoint or setup configuration to allow that port to be accessed. What I've read is that people use some kind of server proxy in front of spring boot. So you don't have the cors error.

@barryoneill
Copy link
Collaborator Author

I think it'd be confusing for people coming to the application to discover there are several competing UIs. What I'd like to do is settle on one UI framework (and one UI), but have branches containing alternatives, should we be considering a switch, or simply using holdmail as a learning project.

@tsneed290
Copy link
Collaborator

I'd have to disagree with @barryoneill here. My scope is to test out new UI technologies. Not to replace Angular or modify the mailhold project in any way. I'm leaning more towards creating a separate project (mailhold-ui-vue) as a means to show off the different UI technology implementations.

@barryoneill
Copy link
Collaborator Author

Sorry, just getting to this now. Yes, confusion on my part (I thought this was Issue #6 ), another project is a great idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants