[PageContainer] Make PageContainer customizable for dynamic routes #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharatkashyap
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Great feature addition! Intuitive to use for the most part.
I think we could benefit greatly from a code snippet or demo showcasing how useActivePage could be used in a Next.js app with the next/navigation primitives. Does it make sense to add one on this page itself, or a separate page to document useActivePage?
|
Added a snippet to the docs on how this would integrate with the next.js app router |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4100
Adds a
titleandbreadCrumbsoverride. Also supplies auseActivePageto retrieve the current value fortitleandbreadCrumbsso they can be extended.https://deploy-preview-4114--mui-toolpad-docs.netlify.app/toolpad/core/react-page-container/#dynamic-routes