Improve mc_report_undefined_behavior_on_fail with correct PENDING TRANSITIONS#157
Open
Improve mc_report_undefined_behavior_on_fail with correct PENDING TRANSITIONS#157
Conversation
c7019de to
2b80e31
Compare
* Before calling mc_report_undefined_behavior_on_fail(), we need to call MCStack::setNextTranstion(), or else the "PENDING TRANSTIONS" displayed to the user will be incorrect. * While this fixes MCCondEnqueue, we will need to apply the same logic to the other transitions. * For testing, try condvar-two-mutexes.c, which has a bug in which the associated mutex of a condition variable is different from the mutex argument of pthread_cond_wait().
2b80e31 to
8c92288
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first commit is a test program that will trigger mc_report_undefined_behavior_on_fail for MCCondEnqueue. When McMini is run on this example, the "PENDING TRANSITIONS" is not correct. Hence, the user would be confused on what was the error.
The second commit fixes the logic in MCCondEnqueue.cpp to correctly display the PENDING TRANSITIONS. The commit message explains the bug and the fix:
This is a draft, since we will need to apply the same fix to the logic of all of the transitions. (And perhaps we can add checks for correct usage of pthread_mutex_lock/unlock, while we're at it.