Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency Symbol for "Swedish Krona" is "Skr" rather than "kr" #47374

Open
ixipixi opened this issue Aug 28, 2024 · 3 comments
Open

Currency Symbol for "Swedish Krona" is "Skr" rather than "kr" #47374

ixipixi opened this issue Aug 28, 2024 · 3 comments
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Team/AdminWebapp Admin and Webapp team Type:Bug Product defects

Comments

@ixipixi
Copy link
Contributor

ixipixi commented Aug 28, 2024

Describe the bug

Customer wants to use the "Unit of Currency" settings but they have avoided doing so because the symbol for the Swedish Krona doesn't match the local convention of "kr".

To Reproduce

  1. Create a question from the orders table
  2. Set a numeric field to currency type of "Swedish Krona"
  3. note that the symbol option is "Skr" and it verified to the left of the field, like "Skr 4.5"

Expected behavior

The unit of currency should match local convention, like "4.5 kr"

Logs

No response

Information about your Metabase installation

v50

Severity

blocking some users

Additional context

Swedish customer wants to use the "Unit of Currency" settings but they have avoided doing so because the symbol for the Swedish Krona doesn't align with local convention.

Custom suffixes aren't a good workaround because of these issues:
@ixipixi ixipixi added Type:Bug Product defects .Needs Triage labels Aug 28, 2024
@alxnddr alxnddr added .Team/AdminWebapp Admin and Webapp team Priority:P3 Cosmetic bugs, minor bugs with a clear workaround and removed .Needs Triage labels Aug 29, 2024
@paoliniluis
Copy link
Contributor

@ixipixi check

metabase/src/metabase/shared/util/currency.cljc

Line 729 in d908592

[:SEK {:symbol "Skr",

@andreasenberg
Copy link

andreasenberg commented Sep 12, 2024 •
edited
Loading

@paoliniluis I'm not sure I understand the point you're trying to make here or how that symbol_native is being used but it is not available as an option in the UI trying to configure metadata for a certain field.
image

If you can shed some light on how symbol_native is used and if there is some configuration we can do to have it render that instead of the symbol "Skr" that would be appreciated.
As a Swede I'm not sure in what situations "Skr" would be used over "kr" to be honest. Personally I've never seen "Skr" used as a symbol for the Swedish Krona. I understand that there might be a case in which you want to distinguish it from its danish counterpart for example but I believe that should be handled in a different way.

@paoliniluis
Copy link
Contributor

@andreasenberg if that’s the case open a PR changing the file i mentioned above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority:P3 Cosmetic bugs, minor bugs with a clear workaround .Team/AdminWebapp Admin and Webapp team Type:Bug Product defects
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@paoliniluis @ixipixi @alxnddr @andreasenberg