Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Columns with long names cause the visualization options sidebar to scroll horizontally #32964

Closed
mazameli opened this issue Aug 4, 2023 · 0 comments · Fixed by #33024
Closed

Columns with long names cause the visualization options sidebar to scroll horizontally #32964

mazameli opened this issue Aug 4, 2023 · 0 comments · Fixed by #33024
Assignees
@shaunlebron
Labels
Priority:P2 Average run of the mill bug Type:Bug Product defects Visualization/Chart Settings
Milestone
0.47

Comments

@mazameli
Copy link
Contributor

mazameli commented Aug 4, 2023

Describe the bug

If the metric or breakout for your viz has a long name (which can easily happen when summarizing a joined column), it causes horizontal scrolling in the viz settings sidebar. This happens with every visualization except Table and Pivot Table.

image

To Reproduce

  1. New question
  2. Make a custom column based on some numeric column, like Subtotal * 2
  3. Give it a long name, like Boy is Maz good at finding and describing bugs
  4. Summarize by getting the sum or average of the custom column and break it out by time like Created At
  5. Visualize
  6. Open the Line Chart settings
  7. See that you have a horizontal scroll now

Expected behavior

We should wrap the name of the column like we do elsewhere

Logs

No response

Information about your Metabase installation

{
  "browser-info": {
    "language": "en-US",
    "platform": "MacIntel",
    "userAgent": "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/115.0.0.0 Safari/537.36",
    "vendor": "Google Inc."
  },
  "system-info": {
    "file.encoding": "UTF-8",
    "java.runtime.name": "OpenJDK Runtime Environment",
    "java.runtime.version": "11.0.11+9",
    "java.vendor": "AdoptOpenJDK",
    "java.vendor.url": "https://adoptopenjdk.net/",
    "java.version": "11.0.11",
    "java.vm.name": "OpenJDK 64-Bit Server VM",
    "java.vm.version": "11.0.11+9",
    "os.name": "Mac OS X",
    "os.version": "11.5",
    "user.language": "en",
    "user.timezone": "America/Los_Angeles"
  },
  "metabase-info": {
    "databases": [
      "h2"
    ],
    "hosting-env": "unknown",
    "application-database": "h2",
    "application-database-details": {
      "database": {
        "name": "H2",
        "version": "2.1.214 (2022-06-13)"
      },
      "jdbc-driver": {
        "name": "H2 JDBC Driver",
        "version": "2.1.214 (2022-06-13)"
      }
    },
    "run-mode": "dev",
    "version": {
      "date": "2022-11-18",
      "src_hash": "09f4ec50c4b6096192e18c140068ce8a7e67434d",
      "tag": "v0.45.1-SNAPSHOT",
      "branch": "maz-make-saving-a-question-less-fear-inducing",
      "hash": "f694966"
    },
    "settings": {
      "report-timezone": null
    }
  }
}

Severity

P2

Additional context

No response
@alxnddr alxnddr assigned alxnddr and unassigned alxnddr Aug 7, 2023
@shaunlebron shaunlebron self-assigned this Aug 8, 2023
@shaunlebron shaunlebron mentioned this issue Aug 8, 2023
Merged
1 task
@shaunlebron shaunlebron added this to the 0.47 milestone Aug 10, 2023
This was referenced Jan 11, 2024
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Merged
Merged
Closed
Merged
Merged
This was referenced Feb 5, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Open
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaunlebron shaunlebron

Labels
Priority:P2 Average run of the mill bug Type:Bug Product defects Visualization/Chart Settings
Projects
None yet
Milestone
0.47
Development

Successfully merging a pull request may close this issue.

Wrap long column names in chart settings sidebar metabase/metabase
5 participants
@shaunlebron @paoliniluis @mazameli @alxnddr @darksciencebase