Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F11 (step in) on mac conflicts with show desktop #5102

Closed
jacdavis opened this issue Apr 8, 2016 · 10 comments
Closed

F11 (step in) on mac conflicts with show desktop #5102

jacdavis opened this issue Apr 8, 2016 · 10 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@jacdavis
Copy link

jacdavis commented Apr 8, 2016

  • VSCode Version: March Insiders
  • OS Version: Mac osx el capitan

Steps to Reproduce:

  1. Start debugging
  2. Hit f11 to step in

EXPECTED: step in
ACTUAL: window minimizes to show the desktop

@isidorn isidorn added this to the May 2016 milestone Apr 28, 2016
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Apr 28, 2016
@isidorn
Copy link
Contributor

isidorn commented May 2, 2016

What others are doing:

  • Chrome debugger on the mac, they use the same keyboard shortcut as us and have the same behavior
  • Xamarin is not using F keys for shorcuts

The F11 show desktop behavior can easily be disabled on the mac. A user can also easily change the step in shorcut that we have.

@weinand @jacdavis I am open for suggestions here. Should we use a different default keyboard shorcut, if yes then which one?

@jacdavis
Copy link
Author

jacdavis commented May 2, 2016

Yes, after I looked into this further, I discovered how to disable the desktop grabbing these shortcuts. This is a tough problem since using different shortcuts may also annoy users, I'm afraid I don't have any other suggestion though. Perhaps adding the command or function key on the mac?

@isidorn
Copy link
Contributor

isidorn commented May 2, 2016

We already have ctrl + F11 to step out. Function + F11 also has native mac behavior (volume up), cmd + f11 could be an option, however changing the current shortcut could break some users which have disabled the default mac behavior
Also cmd + f11 might easily get confused with ctrl + F11.

I would leave it as it is since there are two workarounds (disable natvie mac behvaior, configure step in shortcut in vscode).
I am still open for suggestions though :)

@isidorn
Copy link
Contributor

isidorn commented May 4, 2016

Closing this due to the reasons above.
Will reopen if we somebody has a nice idea on how to tackle this

@isidorn isidorn closed this as completed May 4, 2016
@weinand
Copy link
Contributor

weinand commented May 4, 2016

I've enabled the option to use Fn keys as standard function keys:

2016-05-04 12-31-16

This requires to press the 'fn' key to get the Mac behaviour (e.g. 'Show Desktop') but in this mode I do not have to reconfigure function keys for individual applications.

I think there is no need for VS Code to do anything special here.

@isidorn isidorn assigned weinand and unassigned isidorn May 6, 2016
@weinand weinand added the verified Verification succeeded label May 27, 2016
@lukewlms
Copy link

lukewlms commented Sep 8, 2016

In case anyone reads this thread as I did and still doesn't know how to resolve the conflict, here's how to disable Mac's F11 behavior:

  1. Go to System Preferences -> Keyboard -> Shortcuts
  2. Uncheck the "Show Desktop F11" option

@weinand
Copy link
Contributor

weinand commented Sep 8, 2016

@lukecwilliams so my comment from above (with the screenshot) didn't work for you?

@lukewlms
Copy link

lukewlms commented Sep 8, 2016

@weinand I needed more granular control to solve the issue - whether F keys are on by default or not, I still was getting OSX overriding VS Code's F11 (in one case holding Fn+F11, in the other case hitting F11).

@chadbr
Copy link

chadbr commented Feb 10, 2017

@lukecwilliams thank you!! 2 years of mac and you teach me something new... fantastic.

@RubenNunez
Copy link

@lukecwilliams there is also an excellent solution to this problem. Without disabling "Show Desktop."
Change it to F12!
screen shot 2017-11-02 at 10 26 53

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants