Skip to content

Optimize code#43

Merged
erikaheidi merged 6 commits into
minicli:mainfrom
AbdelrhmanSaid:optimize-code
Jun 20, 2022
Merged

Optimize code#43
erikaheidi merged 6 commits into
minicli:mainfrom
AbdelrhmanSaid:optimize-code

Conversation

@AbdelrhmanSaid

@AbdelrhmanSaid AbdelrhmanSaid commented Jun 7, 2022

Copy link
Copy Markdown
Contributor

Hi there, thanks for your great work 🌟

Changes:

  • Moved readline-ext from suggest to require, because that's a required ext. 😄
  • Preferred php 8 functions, for example replaces substr with str_starts_with when needed.
  • Moved Assests to autoload-dev, because I will not like to have Assests namespace in my production environment.
  • Removed redundant variables & arguments.

I am open to receive your comments ✌️

Comment thread src/Command/CommandRegistry.php
@erikaheidi erikaheidi merged commit 839c9c9 into minicli:main Jun 20, 2022
@erikaheidi

Copy link
Copy Markdown
Member

Thank you @AbdelrhmanSaid , neat improvements! 👍🏼

@AbdelrhmanSaid AbdelrhmanSaid deleted the optimize-code branch June 20, 2022 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants