Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating a delete marker in a suspended prefix #20440

Closed
wants to merge 2 commits into from

Conversation

vadmeste
Copy link
Member

@vadmeste vadmeste commented Sep 16, 2024

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

Fix delete marker creation when only a prefix is supended.

Both DeleteObject and DeleteObjects handlers are affected here

Motivation and Context

How to test this PR?

Create a versioned bucket then,

mc mb myminio/testbucket --with-versioning
mc cp go.mod myminio/testbucket/
mc version enable myminio/testbucket --excluded-prefixes "*"
mc rm myminio/testbucket/go.mod
mc rm myminio/testbucket/go.mod

go.mod is still visible

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@klauspost
Copy link
Contributor

Context?

@vadmeste
Copy link
Member Author

Context?

I updated this ticket comments, I wanted to test our CI/CD before marking this PR as ready

@harshavardhana
Copy link
Member

wait why is this needed?

@harshavardhana
Copy link
Member

Closing this PR, as its not needed. This PR will over extend our implementation with no extra benefits. Check the slack conversation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants