Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add recursive sudirectories and files extraction. #585

Merged
merged 5 commits into from
May 23, 2024
Merged

feat: Add recursive sudirectories and files extraction. #585

merged 5 commits into from
May 23, 2024

Conversation

nepiskopos
Copy link
Contributor

@nepiskopos nepiskopos commented Apr 21, 2024 •
edited
Loading

Pull request type

select from below

  • Feature enhancement --> This one

Which ticket is resolved?

  • None

What does this PR change?

  • Adds the option to set a target directory and extract this directory including all of its subdirectories and the files contained in each subdirectory (including the parent).

Other information

@nepiskopos nepiskopos changed the title Add recursive sudirectories and files extraction. feat: Add recursive sudirectories and files extraction. Apr 23, 2024
@miurahr
Copy link
Owner

miurahr commented May 4, 2024

@nepiskopos Thank you for contribution!

Could you please also update manual document?
You extend API so we need to update the document docs/api.rst and docs/authors.rst

Also please check coding style because of a failure of tox check in CI test.

   py7zr/py7zr.py:564:50: E712 comparison to False should be 'if cond is False:' or 'if not cond:'
  py7zr/py7zr.py:568:52: E712 comparison to True should be 'if cond is True:' or 'if cond:'
  py7zr/py7zr.py:1006:17: BLK100 Black would make changes.
  py7zr/py7zr.py:1006:126: E501 line too long (136 > 125 characters)

You can check your side by running tox -e check

@nepiskopos
Attempt to fix CI issues
fddc379 
Attempt to fix error for Test Python 3.9 on ubuntu-22.04
@nepiskopos
Update documentation and contributors
ba1478c
@miurahr
Copy link
Owner

miurahr commented May 14, 2024 

pip install black
black py7zr/py7zr.py

@nepiskopos
Copy link
Contributor Author 

pip install black
black py7zr/py7zr.py

Thanks, I used black to change line formatting. Maybe the CI failure issues are fixed?

@miurahr miurahr merged commit 4d1cb9b into miurahr:master May 23, 2024
24 checks passed
miurahr added a commit that referenced this pull request Jul 1, 2024
@miurahr
Release v0.21.1
60e4899 
Fixed
-----
* Follow shutil.register_unpack_format() convention of raising a ReadError
  when the library cannot handle a file (#583)
* ensure unpack_7zarchive closes the archive (#584)
* 64bit OS detection (#580)

Added
-----
* Add recursive sub-directories and files extraction (#585)

Changed
-------
* check targets argument type for read and extract method (#577)
* Treat zero byte stream as a file (#551)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nepiskopos @miurahr