Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more license rules #3567

Merged
merged 6 commits into from
Nov 6, 2023
Merged

Add more license rules #3567

merged 6 commits into from
Nov 6, 2023

Conversation

pombredanne
Copy link
Member

@pombredanne pombredanne commented Nov 6, 2023

Add a few new misc. rules to imporve license detection

Tasks

  • Reviewed contribution guidelines
  • PR is descriptively titled 📑 and links the original issue above 🔗
  • Tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
    Run tests locally to check for errors.
  • Commits are in uniquely-named feature branch and has no merge conflicts 📁
  • Looked for possible updates in documentation and added updates if applicable
  • Updated CHANGELOG.rst

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
These are misc. rules, mostly seen in Maven POMs
Also deprecate a few LGPL-3.0 rules that were incorrect and
replace by LGPL-2.1 rules

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
AyanSinhaMahapatra and others added 3 commits November 6, 2023 15:16
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
These are misc. rules, mostly seen in Maven POMs

Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Signed-off-by: Ayan Sinha Mahapatra <ayansmahapatra@gmail.com>
Copy link
Member

@AyanSinhaMahapatra AyanSinhaMahapatra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All green!
LGTM @pombredanne I've added some too
Merging!

@AyanSinhaMahapatra AyanSinhaMahapatra merged commit ae50248 into develop Nov 6, 2023
33 of 34 checks passed
@AyanSinhaMahapatra AyanSinhaMahapatra deleted the more-licenses branch November 6, 2023 12:50
pombredanne added a commit that referenced this pull request Feb 24, 2024
Reference: #3667
Reported-by: Stefan @stefan6419846
Signed-off-by: Philippe Ombredanne <pombredanne@nexb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants