Skip to content

Failing to correctly install G2v5 #4508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cd-alexslater-old opened this issue Dec 22, 2022 · 1 comment · Fixed by #4509
Closed

Failing to correctly install G2v5 #4508

cd-alexslater-old opened this issue Dec 22, 2022 · 1 comment · Fixed by #4509
Assignees
@pearmini
Labels
v5 Latest version related
Milestone
5.0.0-beta.6

Comments

@cd-alexslater-old
Copy link

Hello everyone,

Here is a repo reproducing the issue: https://github.com/cd-alexslater/reproductions

I've been trying to install v5 of G2, but I'm encountering a number of errors in the d.ts files for G2 (see below for a few of them).
image

That error about ActionComponent is particularly confusing as you'll see that typing used to be exported from the index of the module it's being imported from but is now commented out:
image

There's also an error there about importing from 'spec'.. If you change the import to '../spec' it goes away. (this makes sense because spec is a folder up from that file)

Perhaps it's something obvious that I'm missing? Is there some incompatibility with my tsconfig module resolution / target I should be aware of?
@pearmini
Copy link
Member

There are some issues related to types in G2 now. You can update tsconfig.json as follows to solve most of the errors:

{
  "compilerOptions": {
    "target": "es5",
    "moduleResolution": "node",
    "lib": ["dom", "esnext"],
    "esModuleInterop": true,
  }
}

Then there are two left to be solved in G2:

image

You can now set compilerOptions.skipLibCheck to true to skip these issues temporarily.

{
  "compilerOptions": {
    "target": "es5",
    "skipLibCheck": true,
  }
}

I will open a pull request to fix the remaining errors.

@pearmini pearmini self-assigned this Dec 22, 2022
@pearmini pearmini added the v5 Latest version related label Dec 22, 2022
@pearmini pearmini added this to G2 Dec 22, 2022
@pearmini pearmini added this to the 5.0.0-beta.6 milestone Dec 22, 2022
@pearmini pearmini mentioned this issue Dec 22, 2022
Merged
@pearmini pearmini linked a pull request Dec 22, 2022 that will close this issue
fix(types): type errors #4509
Merged
@pearmini pearmini moved this to Done in G2 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pearmini pearmini

Labels
v5 Latest version related
Projects
No open projects
G2
Status: Done
Milestone
5.0.0-beta.6
Development

Successfully merging a pull request may close this issue.

fix(types): type errors antvis/G2
2 participants
@pearmini @cd-alexslater-old