No errors from an invalid mutation or query (Error @typescript-eslint/parser) #268

alexis-regnaud · 2020-05-19T21:33:28Z

Hi,
I am trying to use the eslint-plugin-graphql but it doesn't catch my graphql error.

Here's my eslintrc.js (I've reduced it to the relevant parts only) :

module.exports = {
  env: {
    "browser": true,
    "es6": true
  },
  parser: "@typescript-eslint/parser",
  parserOptions: {
    sourceType: "module",
    ecmaVersion: 2019,
    ecmaFeatures: {
      jsx: true
    },
    project: ["./tsconfig.json"]
  },
  plugins: [
    "react",
    "react-hooks",
    "@typescript-eslint",
    "graphql"
  ],
  extends: [
    'plugin:react/recommended',
    'plugin:@typescript-eslint/recommended'
  ],
  rules: [
    "graphql/template-strings": ['error', {
      env: 'apollo',
      schemaJson: require('./schema.json'),
    }]
  ]
};

In order to cause an eslint error I have defined an explicit issue in my file .gql (I've reduced it to the relevant parts only):

query GetUser() {
    users {
    id
    aFalseField
  }
}

But when I run my eslint pages/** I have no error related to graphql/template-strings.

So I have used eslint with debug mode : eslint pages/** --debug and I have this kind of errors :

Eslint parse all .gql but it seems have a conflict between @typescript-eslint/parser and eslint-plugin-graphql
And if I add 'extraFileExtensions: ['.gql']' in my config I have no conflict but still no lint errors as well ..

Here my packages version :

    "@typescript-eslint/eslint-plugin": "^2.13.0",
    "@typescript-eslint/parser": "^2.34.0",
    "eslint": "^6.8.0",
    "eslint-plugin-graphql": "^3.1.1",
    "eslint-plugin-import": "^2.19.1",
    "eslint-plugin-react": "^7.14.3",
    "eslint-plugin-react-hooks": "^2.3.0",
    "graphql": "^14.5.8",

Note :
The problem is only for separate files, when I use the graphql-tag eslint works well and detect aFalseField

const query = gql `
  users {
    id
    aFalseField
  }
`

The text was updated successfully, but these errors were encountered:

ertrzyiks · 2020-05-20T11:16:51Z

To catch errors in separate files like .gql or .graphql I followed the hint from the readme
https://github.com/apollographql/eslint-plugin-graphql#graphql-literal-files

rules: [
    "graphql/template-strings": ['error', {
      env: 'literal',
      schemaJson: require('./schema.json'),
    }]
  ]

and the linter points out errors in my queries, maybe it will help you too 🤞

alexis-regnaud · 2020-05-20T15:14:46Z

The both together :

rules: [
    "graphql/template-strings": ['error', {
      env: 'literal',
      schemaJson: require('./schema.json'),
    }]
  ]

and

extraFileExtensions: ['.gql']

work fine, I have the errors, thanks !

alexis-regnaud changed the title ~~No errors from an invalid mutation or query~~ No errors from an invalid mutation or query (Error @typescript-eslint/parser) May 19, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

No errors from an invalid mutation or query (Error @typescript-eslint/parser) #268

No errors from an invalid mutation or query (Error @typescript-eslint/parser) #268

alexis-regnaud commented May 19, 2020 •

edited

Loading

ertrzyiks commented May 20, 2020

alexis-regnaud commented May 20, 2020

No errors from an invalid mutation or query (Error @typescript-eslint/parser) #268

No errors from an invalid mutation or query (Error @typescript-eslint/parser) #268

Comments

alexis-regnaud commented May 19, 2020 • edited Loading

ertrzyiks commented May 20, 2020

alexis-regnaud commented May 20, 2020

alexis-regnaud commented May 19, 2020 •

edited

Loading