Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update helm charts based on new docker images #2534

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

pratapalakshmi
Copy link
Collaborator

@pratapalakshmi pratapalakshmi commented Jul 21, 2024

Summary by CodeRabbit

  • New Features

    • Streamlined configuration for multiple services enhancing clarity and maintainability.
    • Introduced new environment-specific parameters for headlessexample, kybapp, workflowsdashboard, and websocketService, improving integration capabilities.
  • Improvements

    • Standardized API endpoint configurations across services for better consistency.
    • Enhanced flexibility in deployment environment configurations with updated parameters.

Copy link

changeset-bot bot commented Jul 21, 2024

⚠️ No Changeset found

Latest commit: 6a87215

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

coderabbitai bot commented Jul 21, 2024

Walkthrough

The recent changes to the example.values.yaml configuration file bring a streamlined approach to service definitions by consolidating application settings across multiple services. Key parameters have been added to enhance environment-specific configurations, improving integration and maintainability. This restructuring focuses on clarity, reducing complexity while standardizing API endpoint configurations, ultimately supporting a more efficient deployment process.

Changes

Files Change Summary
deploy/helm/example.values.yaml Significant restructuring of applicationConfig across services: new parameters added for headlessexample, kybapp, workflowsdashboard, and websocketService. Updates to parameters in workflowService to enhance clarity and consistency.

Poem

In fields of code where bunnies play,
New configs bloom, brightening the way.
With VITE urls hopping in sight,
Our services shine, oh what a delight!
So let’s leap with joy, and cheer this change,
A streamlined path, no need to rearrange! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pratapalakshmi pratapalakshmi requested review from Omri-Levy and liorzam and removed request for liorzam July 21, 2024 13:58
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 5

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 07dd1ca and 6a87215.

Files selected for processing (1)
  • deploy/helm/example.values.yaml (5 hunks)
Additional context used
Gitleaks
deploy/helm/example.values.yaml

269-270: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

Comment on lines +150 to +153
applicationConfig:
VITE_API_URL: http://localhost:3000/api/v1/internal
MODE: development
VITE_IMAGE_LOGO_URL: ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure sensitive data is securely managed.

The VITE_API_URL and other sensitive parameters should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.

-      VITE_API_URL: http://localhost:3000/api/v1/internal
+      VITE_API_URL: ${VITE_API_URL}

Committable suggestion was skipped due to low confidence.

@@ -206,6 +187,7 @@ websocketService:
paths:
- path: /
applicationConfig:
VITE_API_URL: http://localhost:3000/api/v1/internal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure sensitive data is securely managed.

The VITE_API_URL and other sensitive parameters should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.

-    VITE_API_URL: http://localhost:3000/api/v1/internal
+    VITE_API_URL: ${VITE_API_URL}
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
VITE_API_URL: http://localhost:3000/api/v1/internal
VITE_API_URL: ${VITE_API_URL}

Comment on lines +56 to +63
applicationConfig:
VITE_API_URL: http://localhost:3000/api/v1/internal
VITE_API_KEY: secret
VITE_AUTH_ENABLED: true
VITE_MOCK_SERVER: false
VITE_POLLING_INTERVAL: 10
VITE_ASSIGNMENT_POLLING_INTERVAL: 5
VITE_FETCH_SIGNED_URL: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure sensitive data is securely managed.

The VITE_API_KEY and other sensitive parameters should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.

-      VITE_API_KEY: secret
+      VITE_API_KEY: ${VITE_API_KEY}
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
applicationConfig:
VITE_API_URL: http://localhost:3000/api/v1/internal
VITE_API_KEY: secret
VITE_AUTH_ENABLED: true
VITE_MOCK_SERVER: false
VITE_POLLING_INTERVAL: 10
VITE_ASSIGNMENT_POLLING_INTERVAL: 5
VITE_FETCH_SIGNED_URL: false
applicationConfig:
VITE_API_URL: http://localhost:3000/api/v1/internal
VITE_API_KEY: ${VITE_API_KEY}
VITE_AUTH_ENABLED: true
VITE_MOCK_SERVER: false
VITE_POLLING_INTERVAL: 10
VITE_ASSIGNMENT_POLLING_INTERVAL: 5
VITE_FETCH_SIGNED_URL: false

Comment on lines +103 to +110
applicationConfig:
VITE_API_URL: http://localhost:3000/api/v1/internal
VITE_KYB_DEFINITION_ID: "kyb_parent_kyc_session_example"
VITE_API_KEY: secret
VITE_ENVIRONMENT_NAME: local
VITE_DEFAULT_EXAMPLE_TOKEN: 12345678-1234-1234-1234-123456789012
VITE_SENTRY_AUTH_TOKEN: 5
VITE_SENTRY_DSN: false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure sensitive data is securely managed.

The VITE_API_KEY, VITE_SENTRY_AUTH_TOKEN, and other sensitive parameters should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.

-      VITE_API_KEY: secret
+      VITE_API_KEY: ${VITE_API_KEY}
-      VITE_SENTRY_AUTH_TOKEN: 5
+      VITE_SENTRY_AUTH_TOKEN: ${VITE_SENTRY_AUTH_TOKEN}
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
applicationConfig:
VITE_API_URL: http://localhost:3000/api/v1/internal
VITE_KYB_DEFINITION_ID: "kyb_parent_kyc_session_example"
VITE_API_KEY: secret
VITE_ENVIRONMENT_NAME: local
VITE_DEFAULT_EXAMPLE_TOKEN: 12345678-1234-1234-1234-123456789012
VITE_SENTRY_AUTH_TOKEN: 5
VITE_SENTRY_DSN: false
applicationConfig:
VITE_API_URL: http://localhost:3000/api/v1/internal
VITE_KYB_DEFINITION_ID: "kyb_parent_kyc_session_example"
VITE_API_KEY: ${VITE_API_KEY}
VITE_ENVIRONMENT_NAME: local
VITE_DEFAULT_EXAMPLE_TOKEN: 12345678-1234-1234-1234-123456789012
VITE_SENTRY_AUTH_TOKEN: ${VITE_SENTRY_AUTH_TOKEN}
VITE_SENTRY_DSN: false

Comment on lines +235 to +270
BCRYPT_SALT: 10
COMPOSE_PROJECT_NAME: ballerine-x
PORT: 3000
DB_USER: admin
DB_PASSWORD: admin
DB_PORT: 5432
DB_URL: postgres://admin:admin@localhost:5432/postgres
SESSION_SECRET: iGdnj4A0YOhj8dHJK7IWSvQKEZsG7P70FFehuddhFPjtg/bSkzFejYILk4Xue6Ilx9y3IAwzR8pV1gb4
SESSION_EXPIRATION_IN_MINUTES: 60
WORKFLOW_DASHBOARD_CORS_ORIGIN: http://localhost:5200
BACKOFFICE_CORS_ORIGIN: http://localhost:5137
KYB_EXAMPLE_CORS_ORIGIN: http://localhost:5201
KYC_EXAMPLE_CORS_ORIGIN: http://localhost:5202
API_KEY: secret
NODE_ENV: development
ENVIRONMENT_NAME: local
SENTRY_DSN: ""
WEBHOOK_URL: ""
WORKFLOW_DASHBOARD_CORS_ORIGIN: "http://localhost:5200"
KYB_EXAMPLE_CORS_ORIGIN: "http://localhost:5201"
APP_API_URL: https://alon.ballerine.dev
UNIFIED_API_URL: "https://unified-api-test.eu.ballerine.app"
EMAIL_API_TOKEN: ""
EMAIL_API_URL: ""
AWS_S3_BUCKET_NAME: ""
AWS_S3_BUCKET_KEY: ""
AWS_S3_BUCKET_SECRET: ""
AWS_REGION: ""
ADMIN_API_KEY: admin_secret
MAIL_ADAPTER: log
UNIFIED_API_URL: http://localhost:3001
UNIFIED_API_TOKEN: secret-key
UNIFIED_API_SHARED_SECRET: shared-secret-key
SALESFORCE_API_VERSION: 58.0
SALESFORCE_CONSUMER_KEY: ""
SALESFORCE_CONSUMER_SECRET: ""
APP_API_URL: http://localhost:3000
COLLECTION_FLOW_URL: http://localhost:5201
WEB_UI_SDK_URL: http://localhost:5202
HASHING_KEY_SECRET_BASE64: JDJiJDEwJDNFeWtwWEs4QkdiczlRaWFwLkM4Vk8=
NOTION_API_KEY: secret
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ensure sensitive data is securely managed.

The DB_PASSWORD, SESSION_SECRET, API_KEY, EMAIL_API_TOKEN, AWS_S3_BUCKET_KEY, AWS_S3_BUCKET_SECRET, ADMIN_API_KEY, UNIFIED_API_TOKEN, UNIFIED_API_SHARED_SECRET, SALESFORCE_CONSUMER_KEY, SALESFORCE_CONSUMER_SECRET, and NOTION_API_KEY should be securely managed and not hardcoded in the configuration file. Consider using environment variables or a secrets management tool.

-    DB_PASSWORD: admin
+    DB_PASSWORD: ${DB_PASSWORD}
-    SESSION_SECRET: iGdnj4A0YOhj8dHJK7IWSvQKEZsG7P70FFehuddhFPjtg/bSkzFejYILk4Xue6Ilx9y3IAwzR8pV1gb4
+    SESSION_SECRET: ${SESSION_SECRET}
-    API_KEY: secret
+    API_KEY: ${API_KEY}
-    EMAIL_API_TOKEN: ""
+    EMAIL_API_TOKEN: ${EMAIL_API_TOKEN}
-    AWS_S3_BUCKET_KEY: ""
+    AWS_S3_BUCKET_KEY: ${AWS_S3_BUCKET_KEY}
-    AWS_S3_BUCKET_SECRET: ""
+    AWS_S3_BUCKET_SECRET: ${AWS_S3_BUCKET_SECRET}
-    ADMIN_API_KEY: admin_secret
+    ADMIN_API_KEY: ${ADMIN_API_KEY}
-    UNIFIED_API_TOKEN: secret-key
+    UNIFIED_API_TOKEN: ${UNIFIED_API_TOKEN}
-    UNIFIED_API_SHARED_SECRET: shared-secret-key
+    UNIFIED_API_SHARED_SECRET: ${UNIFIED_API_SHARED_SECRET}
-    SALESFORCE_CONSUMER_KEY: ""
+    SALESFORCE_CONSUMER_KEY: ${SALESFORCE_CONSUMER_KEY}
-    SALESFORCE_CONSUMER_SECRET: ""
+    SALESFORCE_CONSUMER_SECRET: ${SALESFORCE_CONSUMER_SECRET}
-    NOTION_API_KEY: secret
+    NOTION_API_KEY: ${NOTION_API_KEY}
Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
BCRYPT_SALT: 10
COMPOSE_PROJECT_NAME: ballerine-x
PORT: 3000
DB_USER: admin
DB_PASSWORD: admin
DB_PORT: 5432
DB_URL: postgres://admin:admin@localhost:5432/postgres
SESSION_SECRET: iGdnj4A0YOhj8dHJK7IWSvQKEZsG7P70FFehuddhFPjtg/bSkzFejYILk4Xue6Ilx9y3IAwzR8pV1gb4
SESSION_EXPIRATION_IN_MINUTES: 60
WORKFLOW_DASHBOARD_CORS_ORIGIN: http://localhost:5200
BACKOFFICE_CORS_ORIGIN: http://localhost:5137
KYB_EXAMPLE_CORS_ORIGIN: http://localhost:5201
KYC_EXAMPLE_CORS_ORIGIN: http://localhost:5202
API_KEY: secret
NODE_ENV: development
ENVIRONMENT_NAME: local
SENTRY_DSN: ""
WEBHOOK_URL: ""
WORKFLOW_DASHBOARD_CORS_ORIGIN: "http://localhost:5200"
KYB_EXAMPLE_CORS_ORIGIN: "http://localhost:5201"
APP_API_URL: https://alon.ballerine.dev
UNIFIED_API_URL: "https://unified-api-test.eu.ballerine.app"
EMAIL_API_TOKEN: ""
EMAIL_API_URL: ""
AWS_S3_BUCKET_NAME: ""
AWS_S3_BUCKET_KEY: ""
AWS_S3_BUCKET_SECRET: ""
AWS_REGION: ""
ADMIN_API_KEY: admin_secret
MAIL_ADAPTER: log
UNIFIED_API_URL: http://localhost:3001
UNIFIED_API_TOKEN: secret-key
UNIFIED_API_SHARED_SECRET: shared-secret-key
SALESFORCE_API_VERSION: 58.0
SALESFORCE_CONSUMER_KEY: ""
SALESFORCE_CONSUMER_SECRET: ""
APP_API_URL: http://localhost:3000
COLLECTION_FLOW_URL: http://localhost:5201
WEB_UI_SDK_URL: http://localhost:5202
HASHING_KEY_SECRET_BASE64: JDJiJDEwJDNFeWtwWEs4QkdiczlRaWFwLkM4Vk8=
NOTION_API_KEY: secret
BCRYPT_SALT: 10
COMPOSE_PROJECT_NAME: ballerine-x
PORT: 3000
DB_USER: admin
DB_PASSWORD: ${DB_PASSWORD}
DB_PORT: 5432
DB_URL: postgres://admin:${DB_PASSWORD}@localhost:5432/postgres
SESSION_SECRET: ${SESSION_SECRET}
SESSION_EXPIRATION_IN_MINUTES: 60
WORKFLOW_DASHBOARD_CORS_ORIGIN: http://localhost:5200
BACKOFFICE_CORS_ORIGIN: http://localhost:5137
KYB_EXAMPLE_CORS_ORIGIN: http://localhost:5201
KYC_EXAMPLE_CORS_ORIGIN: http://localhost:5202
API_KEY: ${API_KEY}
NODE_ENV: development
ENVIRONMENT_NAME: local
SENTRY_DSN: ""
EMAIL_API_TOKEN: ${EMAIL_API_TOKEN}
EMAIL_API_URL: ""
AWS_S3_BUCKET_NAME: ""
AWS_S3_BUCKET_KEY: ${AWS_S3_BUCKET_KEY}
AWS_S3_BUCKET_SECRET: ${AWS_S3_BUCKET_SECRET}
AWS_REGION: ""
ADMIN_API_KEY: ${ADMIN_API_KEY}
MAIL_ADAPTER: log
UNIFIED_API_URL: http://localhost:3001
UNIFIED_API_TOKEN: ${UNIFIED_API_TOKEN}
UNIFIED_API_SHARED_SECRET: ${UNIFIED_API_SHARED_SECRET}
SALESFORCE_API_VERSION: 58.0
SALESFORCE_CONSUMER_KEY: ${SALESFORCE_CONSUMER_KEY}
SALESFORCE_CONSUMER_SECRET: ${SALESFORCE_CONSUMER_SECRET}
APP_API_URL: http://localhost:3000
COLLECTION_FLOW_URL: http://localhost:5201
WEB_UI_SDK_URL: http://localhost:5202
HASHING_KEY_SECRET_BASE64: JDJiJDEwJDNFeWtwWEs4QkdiczlRaWFwLkM4Vk8=
NOTION_API_KEY: ${NOTION_API_KEY}
Tools
Gitleaks

269-270: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.

(generic-api-key)

@pratapalakshmi
Copy link
Collaborator Author

Will re-open once the env variables dist is up and running

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant