From 98a54640b49c88f018ce785bb92020ccd9feadc8 Mon Sep 17 00:00:00 2001 From: David Turner Date: Mon, 4 Apr 2022 13:47:50 -0400 Subject: [PATCH 1/5] small change to test CI on master. --- setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/setup.py b/setup.py index 2aa348d3..5af4ff67 100644 --- a/setup.py +++ b/setup.py @@ -23,6 +23,7 @@ long_description = f.read() + ext_modules = [ Extension( 'brainiak.factoranalysis.tfa_extension', From 52719e775f387691d36282bb6ae9d810ccd80e4b Mon Sep 17 00:00:00 2001 From: David Turner Date: Mon, 4 Apr 2022 14:38:03 -0400 Subject: [PATCH 2/5] Update main.yml run workflow on push --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 24cec168..d34cbbe8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,4 +1,4 @@ -on: [pull_request] +on: [pull_request, push] jobs: pypi: env: From e328380f93dca6ca02f93aca1a8d583fc87a399b Mon Sep 17 00:00:00 2001 From: Dave Turner Date: Sat, 16 Nov 2024 22:12:47 -0500 Subject: [PATCH 3/5] Fix conditional for release. I think the conditional in the workflow for releases was wrong. This is what it shoule be. See here for example: https://github.com/scientific-python/cookie/blob/c7b897cf4f2f4d8f374d112d1fc694d92a2793a7/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/%7B%25%20if%20cookiecutter.__type%3D%3D'compiled'%20%25%7Dcd.yml%7B%25%20endif%20%25%7D#L67 --- .github/workflows/cd.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index 39adf53b..d1cb1004 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -161,7 +161,7 @@ jobs: permissions: id-token: write runs-on: ubuntu-latest - if: github.event_name == 'push' && contains(github.ref, 'refs/tags/v') + if: github.event_name == 'release' && github.event.action == 'published' steps: - uses: actions/download-artifact@v4 with: @@ -181,7 +181,7 @@ jobs: permissions: id-token: write runs-on: ubuntu-latest - if: github.event_name == 'push' && contains(github.ref, 'refs/tags/v') + if: github.event_name == 'release' && github.event.action == 'published' steps: - uses: actions/download-artifact@v4 From cefe6244464a5702396881d1dbf57f7a52b4d028 Mon Sep 17 00:00:00 2001 From: Dave Turner Date: Mon, 25 Nov 2024 14:05:57 -0500 Subject: [PATCH 4/5] Fix anaconda upload. Upload command was just echoing. --- .github/workflows/cd.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index d1cb1004..aea228b7 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -196,5 +196,5 @@ jobs: - name: Upload to Anaconda run: | export ANACONDA_API_TOKEN=${{ secrets.ANACONDA_TOKEN }} - find conda-packages -type f -name "*.tar.bz2" -exec echo "anaconda upload {}" \; + find conda-packages -type f -name "*.tar.bz2" -exec "anaconda upload {}" \; From b315c4df940baf5e1dd41abcfba6391d9047a7c4 Mon Sep 17 00:00:00 2001 From: Dave Turner Date: Mon, 25 Nov 2024 16:47:26 -0500 Subject: [PATCH 5/5] Remove della_notebooks workflow. Need to rework this, removing for now. --- .github/workflows/della_notebooks.yml | 20 -------------------- 1 file changed, 20 deletions(-) delete mode 100644 .github/workflows/della_notebooks.yml diff --git a/.github/workflows/della_notebooks.yml b/.github/workflows/della_notebooks.yml deleted file mode 100644 index 5002b400..00000000 --- a/.github/workflows/della_notebooks.yml +++ /dev/null @@ -1,20 +0,0 @@ -# Workflow file for test runs on Princeton's della cluster. This only runs on self -# hosted runners. The pr-check script detects that it is running on della and -# runs tests of notebooks that require larger resources than GitHub Actions hosted -# runners provide. It would probably be better to move a lot of that logic to this -# file in the future. - -on: [pull_request] - -concurrency: - group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} - cancel-in-progress: true - -jobs: - notebook_tests: - runs-on: self-hosted - steps: - - uses: actions/checkout@v4 - - run: | - chmod a+x pr-check.sh - ./pr-check.sh