From 98a54640b49c88f018ce785bb92020ccd9feadc8 Mon Sep 17 00:00:00 2001 From: David Turner Date: Mon, 4 Apr 2022 13:47:50 -0400 Subject: [PATCH 1/3] small change to test CI on master. --- setup.py | 1 + 1 file changed, 1 insertion(+) diff --git a/setup.py b/setup.py index 2aa348d3..5af4ff67 100644 --- a/setup.py +++ b/setup.py @@ -23,6 +23,7 @@ long_description = f.read() + ext_modules = [ Extension( 'brainiak.factoranalysis.tfa_extension', From 52719e775f387691d36282bb6ae9d810ccd80e4b Mon Sep 17 00:00:00 2001 From: David Turner Date: Mon, 4 Apr 2022 14:38:03 -0400 Subject: [PATCH 2/3] Update main.yml run workflow on push --- .github/workflows/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 24cec168..d34cbbe8 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -1,4 +1,4 @@ -on: [pull_request] +on: [pull_request, push] jobs: pypi: env: From e328380f93dca6ca02f93aca1a8d583fc87a399b Mon Sep 17 00:00:00 2001 From: Dave Turner Date: Sat, 16 Nov 2024 22:12:47 -0500 Subject: [PATCH 3/3] Fix conditional for release. I think the conditional in the workflow for releases was wrong. This is what it shoule be. See here for example: https://github.com/scientific-python/cookie/blob/c7b897cf4f2f4d8f374d112d1fc694d92a2793a7/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/%7B%25%20if%20cookiecutter.__type%3D%3D'compiled'%20%25%7Dcd.yml%7B%25%20endif%20%25%7D#L67 --- .github/workflows/cd.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml index 39adf53b..d1cb1004 100644 --- a/.github/workflows/cd.yml +++ b/.github/workflows/cd.yml @@ -161,7 +161,7 @@ jobs: permissions: id-token: write runs-on: ubuntu-latest - if: github.event_name == 'push' && contains(github.ref, 'refs/tags/v') + if: github.event_name == 'release' && github.event.action == 'published' steps: - uses: actions/download-artifact@v4 with: @@ -181,7 +181,7 @@ jobs: permissions: id-token: write runs-on: ubuntu-latest - if: github.event_name == 'push' && contains(github.ref, 'refs/tags/v') + if: github.event_name == 'release' && github.event.action == 'published' steps: - uses: actions/download-artifact@v4