Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Redis SSL support #902

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Add Redis SSL support #902

wants to merge 15 commits into from

Conversation

afbjorklund
Copy link
Contributor

@afbjorklund afbjorklund commented Jul 18, 2021 •
edited
Loading

See #894 for discussion about TLS/SSL.

gjasny
gjasny reviewed Jul 18, 2021
View reviewed changes
src/CMakeLists.txt Outdated Show resolved Hide resolved
@jrosdahl jrosdahl added the feature New or improved feature label Jul 19, 2021
gjasny
gjasny reviewed Jul 20, 2021
View reviewed changes
test/suites/secondary_rediss.bash Outdated Show resolved Hide resolved
test/CMakeLists.txt Outdated Show resolved Hide resolved
@sschleemilch
Copy link

Is there any update regarding that SSL support implementation?
What is missing? I would be very happy if that would made it into the master and I would be happy to support if necessary and if I am capable of doing so ;-)

@afbjorklund
Copy link
Contributor Author

afbjorklund commented Nov 22, 2021 •
edited
Loading

I think the code has rotten a bit (tests failing) since it is not merged, but I can try to update it...

Originally I think it was scoped out, due to being too costly (startup time and connection time)

@afbjorklund
Copy link
Contributor Author

afbjorklund commented Nov 28, 2021 •
edited
Loading

@sschleemilch updated the branch, and fixed the broken tests and added static build for ssl

cmake -DHIREDIS_FROM_INTERNET=ON -DREDISS_STORAGE_BACKEND=ON

@jrosdahl
Copy link
Member

jrosdahl commented Dec 14, 2021 •
edited
Loading

@sschleemilch wrote:

Is there any update regarding that SSL support implementation? What is missing?

What's missing is some solution to the problems mentioned in #894, especially the first one.

@jrosdahl jrosdahl mentioned this pull request Jun 26, 2022
Closed
@jrosdahl jrosdahl mentioned this pull request Nov 7, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjasny gjasny gjasny left review comments

Assignees
No one assigned
Labels
feature New or improved feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@afbjorklund @sschleemilch @jrosdahl @gjasny