-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING CHANGE: The request '@magenta/music/es6/core' failed to resolve only because it was resolved as fully specified #12
Comments
I don't think the extension should be needed. Have you tried adding it? You can probably just edit the file in your node_modules and check if it solved the problem. This seems to be new in Webpack 5 and causing problems for a lot of people. The easiest thing seems to be to downgrade to Webpack 4. I'm also not super knowledgeable about this, so it would be great if someone more experienced weighed in. I would be afraid of changing something blindly as it might break something in bundlers other than Webpack. |
It should also be said that the setup here is probably a bit fragile, because This is also why I didn't bundle That said, I'm not sure why the message says probably because the origin is a '*.mjs' file or a '*.js' file where the package.json contains '"type": "module"'. Neither of these things is true. But package.json does contain |
This should be fixed in @e7mac Would you like to try this? Unfortunately you may run into the same problem with
|
I got the following error when trying to package the module using webpack into a React app. I'm relatively inexperienced with JS. Does this need us to just change the import to include
.js
? Happy to make a PR if that's the case but wanted to surface it here before making the change.The text was updated successfully, but these errors were encountered: