Fix: `gh pr create`, only fetch teams when reviewers contain a team #11361

BagToad · 2025-07-22T17:03:57Z

See #11360 (comment) for pre-implementation investigation and context.

This proposes a fix for the regression by reintroducing a condition to only fetch teams when a reviewer contains /. This proposes to maintain gh pr edit's existing behavior by continuing to always fetch teams.

Introduces a TeamReviewers boolean to RepoMetadataInput to control whether team reviewers are fetched. Updates RepoMetadata logic to only fetch teams if both Reviewers and TeamReviewers are true. Adds tests to verify correct behavior when TeamReviewers is false.

Updated the logic for fetching team reviewers in PR edit and create flows. In `pr edit`, team reviewers are always fetched for consistency with existing behavior, with a note to potentially align with `pr create` logic in the future. In `pr create`, team reviewers are now only fetched if a reviewer contains a slash, aligning with behavior before the regression.

Copilot

Pull Request Overview

This PR fixes a performance regression in gh pr create by conditionally fetching team data only when reviewers contain a team identifier (indicated by /). The fix addresses issue #11360 where teams were unnecessarily fetched even when no team reviewers were specified.

Added conditional team fetching logic to only fetch teams when reviewer strings contain /
Maintained existing gh pr edit behavior to always fetch teams for backward compatibility
Updated tests to reflect the new conditional behavior

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
pkg/cmd/pr/shared/params.go	Added conditional logic to set TeamReviewers based on presence of `/` in reviewer strings
pkg/cmd/pr/shared/editable.go	Maintained existing behavior for `pr edit` to always fetch teams when reviewers are edited
api/queries_repo.go	Modified RepoMetadata to only fetch teams when both Reviewers and TeamReviewers flags are true
pkg/cmd/pr/create/create_test.go	Removed unnecessary team fetching mock from test
api/queries_repo_test.go	Added test case to verify teams are not fetched when TeamReviewers is false

api/queries_repo_test.go

Replaces manual error check with require.NoError for consistency and improved readability in the test.

andyfeller

Great deep dive into the problem and fix! 🙌

Beyond the questions below, my last one is whether gh pr create and gh pr edit should have information about the permissions needed for using teams as reviewers 🤔

andyfeller · 2025-07-22T17:51:18Z

api/queries_repo.go

 	}

-	if input.Reviewers {
+	if input.Reviewers && input.TeamReviewers {


question:

what conditions will users still encounter the GraphQL: Resource not accessible by integration (organization.teams) error?

GitHub CLI OAuth App?

GitHub Actions automatic token?

why is it important for both Reviewers and TeamReviewers to be set for retrieving organization teams?

I think it'll happen when someone gives us a team (contains a slash), but their auth token does not have perms to fetch teams.

It's technically not important to make this function but it eliminates a situation where the caller might set TeamReviewers to true while Reviewers is false, causing only teams to be fetched and populated into the reviewer metadata. I don't know of a case where we actually want that to happen, so I figure we should guard against callers misusing this field until we know that to be a valid use case by coupling the two fields together.

Thanks for the insight!

For my first question, I was unsure which gh authentication methods include organization team permissions, so I reset my gh auth session and confirmed the read:org scope associated with GitHub CLI OAuth app is good:

$ gh auth status --hostname github.com github.com ✓ Logged in to github.com account andyfeller (keyring) - Active account: true - Git operations protocol: https - Token: gho_************************************ - Token scopes: 'gist', 'read:org', 'repo', 'workflow' $ QUERY=' query { organization(login:"cli"){ teams(first:10, privacy:VISIBLE){ nodes{ slug } } } }' $ gh api graphql -f query="$QUERY" { "data": { "organization": { "teams": { "nodes": [ { "slug": "code-reviewers" }, { "slug": "codespaces" }, { "slug": "deployment-reviewers" }, { "slug": "package-security" }, { "slug": "tuf-root-reviewers" }, { "slug": "webhooks" } ] } } } }

andyfeller · 2025-07-22T18:09:38Z

pkg/cmd/pr/shared/params.go

+			Reviewers: len(tb.Reviewers) > 0,
+			TeamReviewers: len(tb.Reviewers) > 0 && slices.ContainsFunc(tb.Reviewers, func(r string) bool {
+				return strings.ContainsRune(r, '/')
+			}),


question: do we have any tests that should make sure that OrganizationTeams query is excluded when no teams are specified as reviewers?

I see tests like this that include teams:

cli/pkg/cmd/pr/create/create_test.go

Lines 412 to 479 in e5feda3

{

name: "dry-run-nontty-with-all-opts",

tty: false,

setup: func(opts *CreateOptions, t *testing.T) func() {

opts.TitleProvided = true

opts.BodyProvided = true

opts.Title = "TITLE"

opts.Body = "BODY"

opts.BaseBranch = "trunk"

opts.HeadBranch = "feature"

opts.Assignees = []string{"monalisa"}

opts.Labels = []string{"bug", "todo"}

opts.Projects = []string{"roadmap"}

opts.Reviewers = []string{"hubot", "monalisa", "/core", "/robots"}

opts.Milestone = "big one.oh"

opts.DryRun = true

return func() {}

},

httpStubs: func(reg *httpmock.Registry, t *testing.T) {

reg.Register(

httpmock.GraphQL(`query UserCurrent\b`),

httpmock.StringResponse(`{"data": {"viewer": {"login": "OWNER"} } }`))

reg.Register(

httpmock.GraphQL(`query RepositoryAssignableUsers\b`),

httpmock.StringResponse(`

{ "data": { "repository": { "assignableUsers": {

"nodes": [

{ "login": "hubot", "id": "HUBOTID", "name": "" },

{ "login": "MonaLisa", "id": "MONAID", "name": "Mona Display Name" }

],

"pageInfo": { "hasNextPage": false }

} } } }

`))

reg.Register(

httpmock.GraphQL(`query RepositoryLabelList\b`),

httpmock.StringResponse(`

{ "data": { "repository": { "labels": {

"nodes": [

{ "name": "TODO", "id": "TODOID" },

{ "name": "bug", "id": "BUGID" }

],

"pageInfo": { "hasNextPage": false }

} } } }

`))

reg.Register(

httpmock.GraphQL(`query RepositoryMilestoneList\b`),

httpmock.StringResponse(`

{ "data": { "repository": { "milestones": {

"nodes": [

{ "title": "GA", "id": "GAID" },

{ "title": "Big One.oh", "id": "BIGONEID" }

],

"pageInfo": { "hasNextPage": false }

} } } }

`))

reg.Register(

httpmock.GraphQL(`query OrganizationTeamList\b`),

httpmock.StringResponse(`

{ "data": { "organization": { "teams": {

"nodes": [

{ "slug": "core", "id": "COREID" },

{ "slug": "robots", "id": "ROBOTID" }

],

"pageInfo": { "hasNextPage": false }

} } } }

`))

mockRetrieveProjects(t, reg)

},

I only see 1 test that has only human users:

cli/pkg/cmd/pr/create/create_test.go

Lines 1300 to 1382 in e5feda3

{

name: "recover",

tty: true,

httpStubs: func(reg *httpmock.Registry, t *testing.T) {

reg.Register(

httpmock.GraphQL(`query UserCurrent\b`),

httpmock.StringResponse(`{"data": {"viewer": {"login": "OWNER"} } }`))

reg.Register(

httpmock.GraphQL(`query RepositoryAssignableUsers\b`),

httpmock.StringResponse(`

{ "data": { "repository": { "assignableUsers": {

"nodes": [

{ "login": "jillValentine", "id": "JILLID", "name": "Jill Valentine" }

],

"pageInfo": { "hasNextPage": false }

} } } }

`))

reg.Register(

httpmock.GraphQL(`mutation PullRequestCreateRequestReviews\b`),

httpmock.GraphQLMutation(`

{ "data": { "requestReviews": {

"clientMutationId": ""

} } }

`, func(inputs map[string]interface{}) {

assert.Equal(t, []interface{}{"JILLID"}, inputs["userIds"])

}))

reg.Register(

httpmock.GraphQL(`mutation PullRequestCreate\b`),

httpmock.GraphQLMutation(`

{ "data": { "createPullRequest": { "pullRequest": {

"URL": "https://github.com/OWNER/REPO/pull/12"

} } } }

`, func(input map[string]interface{}) {

assert.Equal(t, "recovered title", input["title"].(string))

assert.Equal(t, "recovered body", input["body"].(string))

}))

},

cmdStubs: func(cs *run.CommandStubber) {

cs.Register(`git( .+)? log( .+)? origin/master\.\.\.feature`, 0, "")

},

promptStubs: func(pm *prompter.PrompterMock) {

pm.InputFunc = func(p, d string) (string, error) {

if p == "Title (required)" {

return d, nil

} else {

return "", prompter.NoSuchPromptErr(p)

}

}

pm.MarkdownEditorFunc = func(p, d string, ba bool) (string, error) {

if p == "Body" {

return d, nil

} else {

return "", prompter.NoSuchPromptErr(p)

}

}

pm.SelectFunc = func(p, _ string, opts []string) (int, error) {

if p == "What's next?" {

return 0, nil

} else {

return -1, prompter.NoSuchPromptErr(p)

}

}

},

setup: func(opts *CreateOptions, t *testing.T) func() {

tmpfile, err := os.CreateTemp(t.TempDir(), "testrecover*")

assert.NoError(t, err)

state := shared.IssueMetadataState{

Title: "recovered title",

Body: "recovered body",

Reviewers: []string{"jillValentine"},

}

data, err := json.Marshal(state)

assert.NoError(t, err)

_, err = tmpfile.Write(data)

assert.NoError(t, err)

opts.RecoverFile = tmpfile.Name()

opts.HeadBranch = "feature"

return func() { tmpfile.Close() }

},

expectedOut: "https://github.com/OWNER/REPO/pull/12\n",

expectedErrOut: "\nCreating pull request for feature into master in OWNER/REPO\n\n",

},

If so, then maybe we .Exclude(...) that query from this case?

This test added in the PR removes the OrganizationTeams query mock while setting TeamReviewers to false. This would fail if the OrganizationTeams query actually runs because it won't find a mock for that query.

cli/api/queries_repo_test.go

Lines 217 to 247 in e5feda3

func Test_RepoMetadataTeams(t *testing.T) {

// Test that RepoMetadata only fetches teams if the input specifies it

http := &httpmock.Registry{}

client := newTestClient(http)

repo, _ := ghrepo.FromFullName("OWNER/REPO")

input := RepoMetadataInput{

Reviewers: true,

TeamReviewers: false,

}

http.Register(

httpmock.GraphQL(`query RepositoryAssignableUsers\b`),

httpmock.StringResponse(`

{ "data": { "repository": { "assignableUsers": {

"nodes": [

{ "login": "hubot", "id": "HUBOTID" },

{ "login": "MonaLisa", "id": "MONAID" }

],

"pageInfo": { "hasNextPage": false }

} } } }

`))

http.Register(

httpmock.GraphQL(`query UserCurrent\b`),

httpmock.StringResponse(`

{ "data": { "viewer": { "login": "monalisa" } } }

`))

_, err := RepoMetadata(client, repo, input)

require.NoError(t, err)

}

Thanks 🤔 I guess I was thinking we have a stronger assertion setup to ensure the query was explicitly not called at all close to the gh pr create command since it conditionally includes team reviewers whereas gh pr edit always does:

cli/api/queries_repo_test.go

Lines 287 to 300 in b2348f8

t.Run("when projectsV1 is not supported, does not request them", func(t *testing.T) {

http := &httpmock.Registry{}

client := newTestClient(http)

repo, _ := ghrepo.FromFullName("OWNER/REPO")

http.Exclude(

t,

httpmock.GraphQL(`query RepositoryProjectList\b`),

)

http.Exclude(

t,

httpmock.GraphQL(`query OrganizationProjectList\b`),

)

Okay I spent some time firming up these tests, and I think they're well in the direction you mentioned. I ensured there are tests at the metadata fetcher level and higher up in the pr create tests directly. This should cover all the bases.

addee16
5a6cac3

BagToad · 2025-07-22T19:02:33Z

Great deep dive into the problem and fix! 🙌

Beyond the questions below, my last one is whether gh pr create and gh pr edit should have information about the permissions needed for using teams as reviewers 🤔

I think you're referring to the help docs for those two commands? I don't think it would hurt to document it.

andyfeller · 2025-07-22T19:16:36Z

Beyond the questions below, my last one is whether gh pr create and gh pr edit should have information about the permissions needed for using teams as reviewers 🤔

I think you're referring to the help docs for those two commands? I don't think it would hurt to document it.

You got it. 🙇 Just an errant thought as I was reviewing the usage statement as I didn't see any mention of read:org scope for working with team reviewers.

cli/pkg/cmd/pr/create/create.go

Lines 229 to 233 in b2348f8

    
           			By default, users with write access to the base repository can push new commits to the 
        
           			head branch of the pull request. Disable this with %[1]s--no-maintainer-edit%[1]s. 
        
           			Adding a pull request to projects requires authorization with the %[1]sproject%[1]s scope. 
        
           			To authorize, run %[1]sgh auth refresh -s project%[1]s.

cli/pkg/cmd/pr/edit/edit.go

Lines 61 to 62 in b2348f8

    
           			Editing a pull request's projects requires authorization with the %[1]sproject%[1]s scope. 
        
           			To authorize, run %[1]sgh auth refresh -s project%[1]s.

andyfeller

Looks good to me 💪

Renamed the test to clarify its purpose and added an explicit exclusion for the OrganizationTeamList GraphQL query to ensure teams are only fetched when specified. This improves test accuracy and readability.

Added test cases to verify that teams are fetched when reviewers include teams and not fetched when only users are specified. This ensures correct behavior when requesting reviews from users and teams during pull request creation.

BagToad · 2025-07-23T16:25:52Z

I wanted to also demo that this fix works on the originally reported GHES version 3.14.7:

Reproduction with released binary:

Reproduction with binary built from this branch:

andyfeller

🦸 thank you for the due diligence! ship it

andyfeller · 2025-07-23T17:08:38Z

pkg/cmd/pr/create/create_test.go

+				opts.BodyProvided = true
+				opts.Title = "my title"
+				opts.Body = "my body"
+				opts.Reviewers = []string{"hubot", "monalisa", "org/core", "org/robots"}


praise: I appreciate having the org added rather than leaving it clipped as in other tests

andyfeller · 2025-07-23T17:08:55Z

api/queries_repo_test.go

+	http.Exclude(
+		t,
+		httpmock.GraphQL(`query OrganizationTeamList\b`),
+	)
+


praise: thank you for considering the idea ❤️

This MR contains the following updates: | Package | Update | Change | |---|---|---| | [cli/cli](https://github.com/cli/cli) | minor | `v2.74.2` -> `v2.76.1` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>cli/cli (cli/cli)</summary> ### [`v2.76.1`](https://github.com/cli/cli/releases/tag/v2.76.1): GitHub CLI 2.76.1 [Compare Source](cli/cli@v2.76.0...v2.76.1) #### `gh pr create` regression fix This release fixes a regression introduced in `v2.76.0` where organization teams were retrieved outside of intentional use cases. This caused problems for GitHub Enterprise Server users using the GitHub Actions automatic token that does not have access to organization teams. For more information, see cli/cli#11360 #### What's Changed ##### 🐛 Fixes - Fix: `gh pr create`, only fetch teams when reviewers contain a team by [@BagToad](https://github.com/BagToad) in cli/cli#11361 ##### 📚 Docs & Chores - add tenancy aware for san matcher by [@ejahnGithub](https://github.com/ejahnGithub) in cli/cli#11261 - Run Lint and Tests on `push` to `trunk` branch by [@andyfeller](https://github.com/andyfeller) in cli/cli#11325 - update ownership of pkg/cmd/release/shared/ by [@ejahnGithub](https://github.com/ejahnGithub) in cli/cli#11326 - Automate spam issue detection by [@babakks](https://github.com/babakks) in cli/cli#11316 - Improve `api` `--preview` docs by [@jsoref](https://github.com/jsoref) in cli/cli#11274 - Incorporate govulncheck into workflows by [@andyfeller](https://github.com/andyfeller) in cli/cli#11332 - chore(deps): bump advanced-security/filter-sarif from 1.0.0 to 1.0.1 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11298 - chore(deps): bump github.com/sigstore/sigstore-go from 1.0.0 to 1.1.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11307 **Full Changelog**: cli/cli@v2.76.0...v2.76.1 ### [`v2.76.0`](https://github.com/cli/cli/releases/tag/v2.76.0): GitHub CLI 2.76.0 [Compare Source](cli/cli@v2.75.1...v2.76.0) ####

Copilot Coding Agent Support GitHub Copilot Pro+ and Copilot Enterprise subscribers can now assign issues to GitHub Copilot during issue creation using: - Command-line flag: `gh issue create --assignee @copilot` - Launching web browser: `gh issue create --assignee @copilot --web` - Or interactively selecting `Copilot (AI)` as assignee in `gh issue create` metadata For more details, refer to [the full changelog post for Copilot coding agent](https://github.blog/changelog/2025-05-19-github-copilot-coding-agent-in-public-preview/). #### What's Changed ##### ✨ Features - Assign Copilot during `gh issue create` by [@andyfeller](https://github.com/andyfeller) in cli/cli#11279 - Display immutable field in `release view` command by [@bdehamer](https://github.com/bdehamer) in cli/cli#11251 ##### 🐛 Fixes - FIX: Do not fetch logs for skipped jobs by [@babakks](https://github.com/babakks) in cli/cli#11312 - Transform `extension` and `filename` qualifiers into `path` qualifier for web code search by [@samcoe](https://github.com/samcoe) in cli/cli#11211 ##### 📚 Docs & Chores - FIX: Workflow does not contain permissions by [@BagToad](https://github.com/BagToad) in cli/cli#11322 - Add automated feature request response workflow by [@BagToad](https://github.com/BagToad) in cli/cli#11299 **Full Changelog**: cli/cli@v2.75.1...v2.76.0 ### [`v2.75.1`](https://github.com/cli/cli/releases/tag/v2.75.1): GitHub CLI 2.75.1 [Compare Source](cli/cli@v2.75.0...v2.75.1) #### What's Changed ##### 🐛 Fixes - Ensure hostnames are visible in CLI website by [@andyfeller](https://github.com/andyfeller) in cli/cli#11295 - Revert "Fix: `gh pr create` prioritize `--title` and `--body` over `--fill` when `--web` is present" by [@andyfeller](https://github.com/andyfeller) in cli/cli#11300 ##### 📚 Docs & Chores - Ensure go directive is always .0 version in bump by [@williammartin](https://github.com/williammartin) in cli/cli#11259 - Minor (1-word) documentation typo in generated `~/.config/gh/config.yml` by [@kurahaupo](https://github.com/kurahaupo) in cli/cli#11246 - Automate closing of stale issues by [@babakks](https://github.com/babakks) in cli/cli#11268 - Filter the `third-party/` folder out of CodeQL results by [@BagToad](https://github.com/BagToad) in cli/cli#11278 - Exclude `third-party` source from golangci-lint by [@andyfeller](https://github.com/andyfeller) in cli/cli#11293 #####

Dependencies - Bump Go to 1.24.5 by [@github-actions](https://github.com/github-actions)\[bot] in cli/cli#11255 - chore(deps): bump github.com/sigstore/protobuf-specs from 0.4.3 to 0.5.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11263 - chore(deps): bump golang.org/x/term from 0.32.0 to 0.33.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11266 - chore(deps): bump golang.org/x/sync from 0.15.0 to 0.16.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11264 - chore(deps): bump golang.org/x/text from 0.26.0 to 0.27.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11265 - chore(deps): bump golang.org/x/crypto from 0.39.0 to 0.40.0 by [@dependabot](https://github.com/dependabot)\[bot] in cli/cli#11275 #### New Contributors - [@kurahaupo](https://github.com/kurahaupo) made their first contribution in cli/cli#11246 - [@github-actions](https://github.com/github-actions)\[bot] made their first contribution in cli/cli#11255 **Full Changelog**: cli/cli@v2.75.0...v2.75.1 ### [`v2.75.0`](https://github.com/cli/cli/releases/tag/v2.75.0): GitHub CLI 2.75.0 [Compare Source](cli/cli@v2.74.2...v2.75.0) #### What's Changed ##### ✨ Features - init release verify subcommands by [@ejahnGithub](https://github.com/ejahnGithub) in cli/cli#11018 - Embed Windows resources (VERSIONINFO) during build by [@babakks](https://github.com/babakks) in cli/cli#11048 - Support `--no-repos-selected` on `gh secret set` by [@williammartin](https://github.com/williammartin) in cli/cli#11217 ##### 🐛 Fixes - Fix: `gh pr create` prioritize `--title` and `--body` over `--fill` when `--web` is present by [@dankrzeminski32](https://github.com/dankrzeminski32) in cli/cli#10547 - fix: get token for active user instead of blank if possible by [@anuraaga](https://github.com/anuraaga) in cli/cli#11038 - Use Actions API to retrieve job run logs as a fallback mechanism by [@babakks](https://github.com/babakks) in cli/cli#11172 - Fix query object state mutation during pagination by [@babakks](https://github.com/babakks) in cli/cli#11244 - Handle `HTTP 404` when deleting remote branch in `pr merge` by [@babakks](https://github.com/babakks) in cli/cli#11234 ##### 📚 Docs & Chores - chore: fix function name by [@jinjingroad](https://github.com/jinjingroad) in cli/cli#11149 - chore: update Go version to 1.24 in devcontainer configuration and docs by [@tMinamiii](https://github.com/tMinamiii) in cli/cli#11158 - Ensure lint workflow checks whether 3rd party license and code is up to date by [@andyfeller](https://github.com/andyfeller) in cli/cli#11047 - docs: install\_linux.md: add Solus linux install instructions by [@chax](https://github.com/chax) in cli/cli#10823 - Fix missing newline in install\_linux.md by [@BagToad](https://github.com/BagToad) in cli/cli#11160 - Ensure automation uses pinned go-licenses version by [@andyfeller](https://github.com/andyfeller) in cli/cli#11161 - Add `workflow_dispatch` support to MR Help Wanted check by [@BagToad](https://github.com/BagToad) in cli/cli#11179 - Remove unused `GH_TOKEN` env variable from workflow by [@BagToad](https://github.com/BagToad) in cli/cli#11190 - Add workflow to automate go version bumping by [@williammartin](https://github.com/williammartin) in cli/cli#11189 - Fix inconsistent use of tabs and spaces by [@Stefan-Heimersheim](https://github.com/Stefan-Heimersheim) in cli/cli#11194 - Decouple arg parsing from MR finder by [@babakks](https://github.com/babakks) in cli/cli#11192 - docs: consistently use `apt` in installation instructions by [@tklauser](https://github.com/tklauser) in cli/cli#11216 - Ensure bump go script has git user configured by [@williammartin](https://github.com/williammartin) in cli/cli#11229 - Inject token into bump-go workflow by [@williammartin](https://github.com/williammartin) in cli/cli#11233 - Reinstating Primer Style CLI content within `cli/cli` repository by [@andyfeller](https://github.com/andyfeller) in cli/cli#11060 - Add setup-go to bump-go workflow by [@williammartin](https://github.com/williammartin) in cli/cli#11237 - Ensure GoReleaser does not break on Mac OS and Linux when skipping Windows `.rsyso` generation script by [@andyfeller](https://github.com/andyfeller) in cli/cli#11257 #####

Dependencies - Bump all dependencies except dev-tunnels by [@williammartin](https://github.com/williammartin) in cli/cli#11203 - Update microsoft dev-tunnels to v0.1.13 by [@williammartin](https://github.com/williammartin) in cli/cli#11205 - Consume dependabot minor versions for go modules by [@williammartin](https://github.com/williammartin) in cli/cli#11213 #### New Contributors - [@jinjingroad](https://github.com/jinjingroad) made their first contribution in cli/cli#11149 - [@tMinamiii](https://github.com/tMinamiii) made their first contribution in cli/cli#11158 - [@chax](https://github.com/chax) made their first contribution in cli/cli#10823 - [@dankrzeminski32](https://github.com/dankrzeminski32) made their first contribution in cli/cli#10547 - [@anuraaga](https://github.com/anuraaga) made their first contribution in cli/cli#11038 - [@Stefan-Heimersheim](https://github.com/Stefan-Heimersheim) made their first contribution in cli/cli#11194 **Full Changelog**: cli/cli@v2.74.2...v2.75.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).

BagToad added 2 commits July 22, 2025 10:47

Copilot AI review requested due to automatic review settings July 22, 2025 17:03

BagToad requested a review from a team as a code owner July 22, 2025 17:03

BagToad requested a review from babakks July 22, 2025 17:03

BagToad temporarily deployed to cli-automation July 22, 2025 17:04 — with GitHub Actions Inactive

cliAutomation assigned BagToad Jul 22, 2025

Copilot AI reviewed Jul 22, 2025

View reviewed changes

api/queries_repo_test.go Show resolved Hide resolved

BagToad requested a review from andyfeller July 22, 2025 17:04

Refactor error assertion in Test_RepoMetadataTeams

e5feda3

Replaces manual error check with require.NoError for consistency and improved readability in the test.

andyfeller reviewed Jul 22, 2025

View reviewed changes

andyfeller approved these changes Jul 22, 2025

View reviewed changes

BagToad added 2 commits July 23, 2025 09:59

Refactor and improve RepoMetadata teams test

addee16

Renamed the test to clarify its purpose and added an explicit exclusion for the OrganizationTeamList GraphQL query to ensure teams are only fetched when specified. This improves test accuracy and readability.

Add tests for reviewer team handling in PR creation

5a6cac3

Added test cases to verify that teams are fetched when reviewers include teams and not fetched when only users are specified. This ensures correct behavior when requesting reviews from users and teams during pull request creation.

andyfeller approved these changes Jul 23, 2025

View reviewed changes

andyfeller merged commit 0d80c36 into trunk Jul 23, 2025
11 checks passed

andyfeller deleted the kw/cli-11360-regression-gh-pr-create-fails-on-self-hosted-runner-in-v2760-resource-not-accessible-by-integration-organizationteams branch July 23, 2025 17:09

This comment was marked as spam.

Sign in to view

benjyw mentioned this pull request Sep 3, 2025

A GH action to automate periodic creation of a new RunsOn AMI pantsbuild/pants#22605

Merged

	{
	name: "dry-run-nontty-with-all-opts",
	tty: false,
	setup: func(opts CreateOptions, t testing.T) func() {
	opts.TitleProvided = true
	opts.BodyProvided = true
	opts.Title = "TITLE"
	opts.Body = "BODY"
	opts.BaseBranch = "trunk"
	opts.HeadBranch = "feature"
	opts.Assignees = []string{"monalisa"}
	opts.Labels = []string{"bug", "todo"}
	opts.Projects = []string{"roadmap"}
	opts.Reviewers = []string{"hubot", "monalisa", "/core", "/robots"}
	opts.Milestone = "big one.oh"
	opts.DryRun = true
	return func() {}
	},
	httpStubs: func(reg httpmock.Registry, t testing.T) {
	reg.Register(
	httpmock.GraphQL(`query UserCurrent\b`),
	httpmock.StringResponse(`{"data": {"viewer": {"login": "OWNER"} } }`))
	reg.Register(
	httpmock.GraphQL(`query RepositoryAssignableUsers\b`),
	httpmock.StringResponse(`
	{ "data": { "repository": { "assignableUsers": {
	"nodes": [
	{ "login": "hubot", "id": "HUBOTID", "name": "" },
	{ "login": "MonaLisa", "id": "MONAID", "name": "Mona Display Name" }
	],
	"pageInfo": { "hasNextPage": false }
	} } } }
	`))
	reg.Register(
	httpmock.GraphQL(`query RepositoryLabelList\b`),
	httpmock.StringResponse(`
	{ "data": { "repository": { "labels": {
	"nodes": [
	{ "name": "TODO", "id": "TODOID" },
	{ "name": "bug", "id": "BUGID" }
	],
	"pageInfo": { "hasNextPage": false }
	} } } }
	`))
	reg.Register(
	httpmock.GraphQL(`query RepositoryMilestoneList\b`),
	httpmock.StringResponse(`
	{ "data": { "repository": { "milestones": {
	"nodes": [
	{ "title": "GA", "id": "GAID" },
	{ "title": "Big One.oh", "id": "BIGONEID" }
	],
	"pageInfo": { "hasNextPage": false }
	} } } }
	`))
	reg.Register(
	httpmock.GraphQL(`query OrganizationTeamList\b`),
	httpmock.StringResponse(`
	{ "data": { "organization": { "teams": {
	"nodes": [
	{ "slug": "core", "id": "COREID" },
	{ "slug": "robots", "id": "ROBOTID" }
	],
	"pageInfo": { "hasNextPage": false }
	} } } }
	`))
	mockRetrieveProjects(t, reg)
	},

	{
	name: "recover",
	tty: true,
	httpStubs: func(reg httpmock.Registry, t testing.T) {
	reg.Register(
	httpmock.GraphQL(`query UserCurrent\b`),
	httpmock.StringResponse(`{"data": {"viewer": {"login": "OWNER"} } }`))
	reg.Register(
	httpmock.GraphQL(`query RepositoryAssignableUsers\b`),
	httpmock.StringResponse(`
	{ "data": { "repository": { "assignableUsers": {
	"nodes": [
	{ "login": "jillValentine", "id": "JILLID", "name": "Jill Valentine" }
	],
	"pageInfo": { "hasNextPage": false }
	} } } }
	`))
	reg.Register(
	httpmock.GraphQL(`mutation PullRequestCreateRequestReviews\b`),
	httpmock.GraphQLMutation(`
	{ "data": { "requestReviews": {
	"clientMutationId": ""
	} } }
	`, func(inputs map[string]interface{}) {
	assert.Equal(t, []interface{}{"JILLID"}, inputs["userIds"])
	}))
	reg.Register(
	httpmock.GraphQL(`mutation PullRequestCreate\b`),
	httpmock.GraphQLMutation(`
	{ "data": { "createPullRequest": { "pullRequest": {
	"URL": "https://github.com/OWNER/REPO/pull/12"
	} } } }
	`, func(input map[string]interface{}) {
	assert.Equal(t, "recovered title", input["title"].(string))
	assert.Equal(t, "recovered body", input["body"].(string))
	}))
	},
	cmdStubs: func(cs *run.CommandStubber) {
	cs.Register(`git( .+)? log( .+)? origin/master\.\.\.feature`, 0, "")
	},
	promptStubs: func(pm *prompter.PrompterMock) {
	pm.InputFunc = func(p, d string) (string, error) {
	if p == "Title (required)" {
	return d, nil
	} else {
	return "", prompter.NoSuchPromptErr(p)
	}
	}
	pm.MarkdownEditorFunc = func(p, d string, ba bool) (string, error) {
	if p == "Body" {
	return d, nil
	} else {
	return "", prompter.NoSuchPromptErr(p)
	}
	}
	pm.SelectFunc = func(p, _ string, opts []string) (int, error) {
	if p == "What's next?" {
	return 0, nil
	} else {
	return -1, prompter.NoSuchPromptErr(p)
	}
	}
	},
	setup: func(opts CreateOptions, t testing.T) func() {
	tmpfile, err := os.CreateTemp(t.TempDir(), "testrecover*")
	assert.NoError(t, err)
	state := shared.IssueMetadataState{
	Title: "recovered title",
	Body: "recovered body",
	Reviewers: []string{"jillValentine"},
	}
	data, err := json.Marshal(state)
	assert.NoError(t, err)
	_, err = tmpfile.Write(data)
	assert.NoError(t, err)

	opts.RecoverFile = tmpfile.Name()
	opts.HeadBranch = "feature"
	return func() { tmpfile.Close() }
	},
	expectedOut: "https://github.com/OWNER/REPO/pull/12\n",
	expectedErrOut: "\nCreating pull request for feature into master in OWNER/REPO\n\n",
	},

	func Test_RepoMetadataTeams(t *testing.T) {
	// Test that RepoMetadata only fetches teams if the input specifies it
	http := &httpmock.Registry{}
	client := newTestClient(http)
	repo, _ := ghrepo.FromFullName("OWNER/REPO")
	input := RepoMetadataInput{
	Reviewers: true,
	TeamReviewers: false,
	}

	http.Register(
	httpmock.GraphQL(`query RepositoryAssignableUsers\b`),
	httpmock.StringResponse(`
	{ "data": { "repository": { "assignableUsers": {
	"nodes": [
	{ "login": "hubot", "id": "HUBOTID" },
	{ "login": "MonaLisa", "id": "MONAID" }
	],
	"pageInfo": { "hasNextPage": false }
	} } } }
	`))

	http.Register(
	httpmock.GraphQL(`query UserCurrent\b`),
	httpmock.StringResponse(`
	{ "data": { "viewer": { "login": "monalisa" } } }
	`))

	_, err := RepoMetadata(client, repo, input)
	require.NoError(t, err)
	}

	t.Run("when projectsV1 is not supported, does not request them", func(t *testing.T) {
	http := &httpmock.Registry{}
	client := newTestClient(http)

	repo, _ := ghrepo.FromFullName("OWNER/REPO")

	http.Exclude(
	t,
	httpmock.GraphQL(`query RepositoryProjectList\b`),
	)
	http.Exclude(
	t,
	httpmock.GraphQL(`query OrganizationProjectList\b`),
	)

Fix: gh pr create, only fetch teams when reviewers contain a team #11361

Fix: gh pr create, only fetch teams when reviewers contain a team #11361

Uh oh!

Conversation

BagToad commented Jul 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

andyfeller left a comment

Choose a reason for hiding this comment

Uh oh!

andyfeller Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

BagToad Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andyfeller Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

andyfeller Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

BagToad Jul 22, 2025

Choose a reason for hiding this comment

Uh oh!

andyfeller Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BagToad Jul 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

BagToad commented Jul 22, 2025

Uh oh!

andyfeller commented Jul 22, 2025

Uh oh!

andyfeller left a comment

Choose a reason for hiding this comment

Uh oh!

BagToad commented Jul 23, 2025

Uh oh!

andyfeller left a comment

Choose a reason for hiding this comment

Uh oh!

andyfeller Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

andyfeller Jul 23, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

Uh oh!

Fix: `gh pr create`, only fetch teams when reviewers contain a team #11361

Fix: `gh pr create`, only fetch teams when reviewers contain a team #11361

BagToad Jul 22, 2025 •

edited

Loading

andyfeller Jul 22, 2025 •

edited

Loading

BagToad Jul 23, 2025 •

edited

Loading