Convert a few words to more inclusive ones #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the code base more inclusive, I've changed a few variable names from "master*" to "primary*". [NO NEW TESTS NEEDED] Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
Luap99
requested changes
Jan 21, 2023
Member
Luap99
left a comment
There was a problem hiding this comment.
I disagree with this change, the correct name is master. That is how it is defined in the kernel netlink API. Renaming just makes it harder to understand the code IMO.
Luap99
approved these changes
Jan 23, 2023
Member
Luap99
left a comment
There was a problem hiding this comment.
Based on internal discussion, LGTM
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flouthoc, Luap99, TomSweeneyRedHat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the code base more inclusive, I've changed a few variable names from "master*" to "primary*".
[NO NEW TESTS NEEDED]
Signed-off-by: tomsweeneyredhat tsweeney@redhat.com