Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect variable scoping for Displays To Summarize Relational Items extension guide #22710

Closed
ComfortablyCoding opened this issue Jun 10, 2024 · 0 comments · Fixed by #23665
Closed

Incorrect variable scoping for Displays To Summarize Relational Items extension guide #22710

ComfortablyCoding opened this issue Jun 10, 2024 · 0 comments · Fixed by #23665
Assignees
@ComfortablyCoding
Labels
Bug ⭐️ Good First Issue

Comments

@ComfortablyCoding
Copy link
Contributor

Page

https://docs.directus.io/guides/extensions/displays-relational-summaries.html#complete-code

Describe the Inaccuracy

The displayTemplateMeta variable in the interface options function is incorrectly scoped resulting in it not being accessible in the returned array. Ideally this would be defined as a let outside the if/else block to mitigate this issue.

Screenshot 2024-06-10 at 10 42 17 AM
@ComfortablyCoding ComfortablyCoding changed the title Incorrect variable scoping for Displays To Summarize Relational Items example Incorrect variable scoping for Displays To Summarize Relational Items extension example Jun 10, 2024
@ComfortablyCoding ComfortablyCoding changed the title Incorrect variable scoping for Displays To Summarize Relational Items extension example Incorrect variable scoping for Displays To Summarize Relational Items extension Jun 10, 2024
@ComfortablyCoding ComfortablyCoding changed the title Incorrect variable scoping for Displays To Summarize Relational Items extension Incorrect variable scoping for Displays To Summarize Relational Items extension guide Jun 10, 2024
@rijkvanzanten rijkvanzanten added the Bug label Sep 2, 2024 — with Linear
@ComfortablyCoding ComfortablyCoding mentioned this issue Sep 13, 2024
Merged
@ComfortablyCoding ComfortablyCoding self-assigned this Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ComfortablyCoding ComfortablyCoding

Labels
Bug ⭐️ Good First Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix variable scoping in Displays To Summarize Relational Items guide directus/directus
2 participants
@rijkvanzanten @ComfortablyCoding