Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEP 7, incomplete sentence/thought line 28 #32

Open
ssteinerx opened this issue Nov 7, 2016 · 1 comment
Open

DEP 7, incomplete sentence/thought line 28 #32

ssteinerx opened this issue Nov 7, 2016 · 1 comment

Comments

@ssteinerx
Copy link

@jacobian

In DEP 7 at line 28:

28: ...community and core team that the chosen dependency...

The sentence just dangles off into space there...

Unfortunately, there's no way to make a line-comment without editing the document and I'm not sure how verbose/specific you want to be here or whether that was just a repeat of the prior sentence that got left hanging accidentally.
@manikishannayak
Copy link

I see the sentence you're referring to in DEP 7. It does seem incomplete and may be a typo or formatting issue. It appears to be a continuation of the previous sentence but was left hanging. Here's how it might be corrected:

Original:

In a nutshell, the policy is that adding a new external dependency should be treated similarly to adding a major new feature to Django: it requires a DEP, demonstration that the dependency is needed, rough consensus among the community and core team that the chosen dependency, and a final decision by the Technical Board.

Correction:

In a nutshell, the policy is that adding a new external dependency should be treated similarly to adding a major new feature to Django. It requires a DEP, demonstration that the dependency is needed, rough consensus among the community and core team that the chosen dependency is necessary, and a final decision by the Technical Board.

This correction makes the sentence more coherent by completing the thought and providing clarity on what the policy entails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ssteinerx @manikishannayak