You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
node_modules/graphql-yoga/node_modules/lru-cache/dist/commonjs/index.d.ts:985:5 - error TS2416: Property 'keys' in type 'LRUCache<K, V, FC>' is not assignable to the same property in base type 'Map<K, V>'.
Type '() => Generator<K, void, unknown>' is not assignable to type '() => MapIterator<K>'.
Call signature return types 'Generator<K, void, unknown>' and 'MapIterator<K>' are incompatible.
The types returned by 'next(...)' are incompatible between these types.
Type 'IteratorResult<K, void>' is not assignable to type 'IteratorResult<K, undefined>'.
Type 'IteratorReturnResult<void>' is not assignable to type 'IteratorResult<K, undefined>'.
Type 'IteratorReturnResult<void>' is not assignable to type 'IteratorReturnResult<undefined>'.
Type 'void' is not assignable to type 'undefined'.
985 keys(): Generator<K, void, unknown>;
Your Example Website or App
N/A
Steps to Reproduce the Bug or Issue
Install graphql-yoga 5.x
Run tsc with TS 5.6
Expected behavior
Compiles successfully
Screenshots or Videos
No response
Platform
OS: macOS
NodeJS: 20.12.2
@graphql-yoga/* version(s): 5.6.1
Additional context
lru-cache v10.x doesn't seem to be compatible with TS 5.6, but lru-cache v11 seems to be fine. Upgrading would require dropping support for node less 20 though, so this would require graphql-yoga to go to v6. Maybe it's time?
The text was updated successfully, but these errors were encountered:
Same issue. The tsconfig setting "strictBuiltinIteratorReturn": false prevents the error, but it would be nice to keep it enabled. FYI isaacs/node-lru-cache#354 lru cache issue has been recently fixed in the source library so hopefully the dependency can be fixed.
Describe the bug
The build fails compiling with TS 5.6:
Your Example Website or App
N/A
Steps to Reproduce the Bug or Issue
Expected behavior
Compiles successfully
Screenshots or Videos
No response
Platform
@graphql-yoga/*
version(s): 5.6.1Additional context
lru-cache v10.x doesn't seem to be compatible with TS 5.6, but lru-cache v11 seems to be fine. Upgrading would require dropping support for node less 20 though, so this would require graphql-yoga to go to v6. Maybe it's time?
The text was updated successfully, but these errors were encountered: