Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install htmltest using it's install script once the next release becomes available #459

Closed
chalin opened this issue Aug 23, 2021 · 3 comments
Closed

Install htmltest using it's install script once the next release becomes available #459

chalin opened this issue Aug 23, 2021 · 3 comments
Assignees
@chalin
Labels
infrastructure Categorizes issue or PR as related to site infrastructure.

Comments

@chalin
Copy link
Contributor

chalin commented Aug 23, 2021 •
edited
Loading

To check links you'll need htmltest@Head in your path, unless you have go installed, then npm run check-links will fetch and build the required version for your. (That is, the current release 0.14.0 won't work.)

Otherwise, you can let Netlify check links for you as part of preview builds.

This issue is a reminder to update the Makefile to revert to using the htmltest install script once a new release (>0.14) becomes available.

Context:

website/Makefile

Lines 22 to 37 in 2a33bf5

# Until htmltext >0.14.x is released, get and build our own from source:
get-link-checker:
rm -Rf $(HTMLTEST_DIR)
mkdir -p $(HTMLTEST_DIR)/bin && \
cd $(HTMLTEST_DIR) && \
git clone --depth=1 https://github.com/wjdp/htmltest.git && \
( \
cd htmltest && \
./build.sh && \
cp bin/htmltest ../bin \
)
# Once htmltext >0.14.x is released, replace the get-and-build code above with this:
# get-link-checker:
# rm -Rf $(HTMLTEST_DIR)/bin
# curl https://htmltest.wjdp.uk | bash -s -- -b $(HTMLTEST_DIR)/bin

@chalin chalin added the infrastructure Categorizes issue or PR as related to site infrastructure. label Aug 23, 2021
@chalin chalin self-assigned this Aug 23, 2021
@chalin
Copy link
Contributor Author

chalin commented Sep 16, 2021

I'm starting to think that we might want to keep that Makefile target renamed to, say, build-link-checker.

@dwelsch-esi
Copy link
Contributor

This change seems to have been made in the website/Makefile. Can this issue be closed?

@jmhbnz
Copy link
Member

jmhbnz commented Jan 2, 2024

This change seems to have been made in the website/Makefile. Can this issue be closed?

Agree thanks for the prompt @dwelsch-esi. Closing.

@jmhbnz jmhbnz closed this as completed Jan 2, 2024
@naiba4 naiba4 mentioned this issue Jan 29, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chalin chalin

Labels
infrastructure Categorizes issue or PR as related to site infrastructure.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chalin @jmhbnz @dwelsch-esi