Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BookStore] Inconsistent price per book? #696

Open
ls1955 opened this issue Sep 17, 2024 · 7 comments
Open

[BookStore] Inconsistent price per book? #696

ls1955 opened this issue Sep 17, 2024 · 7 comments

Comments

@ls1955
Copy link
Contributor

ls1955 commented Sep 17, 2024

Exercise's instructions said book price is $8, though it seems like book price in specs are $800, is it intentional?

@ryanplusplus
Copy link
Member

ryanplusplus commented Sep 17, 2024

Confusingly, the prices are in cents, not dollars. The upstream problem specification indicates that floats should not be used and a language-appropriate fixed point format should be used instead. I'm not aware of any built-in support so using an integer representation of price as cents is the way we went.

@ls1955
Copy link
Contributor Author

ls1955 commented Sep 17, 2024

Thanks for the explanation. Should we change the dollars in instruction to cents, or just leave it as it is?

@meatball133
Copy link
Member

We are not going to change the instructions, what can be done is an append.

@ls1955
Copy link
Contributor Author

ls1955 commented Sep 17, 2024

Append as in mentioning the specs use cent instead of dollar at the end of instructions?

@meatball133
Copy link
Member

@ls1955
Copy link
Contributor Author

ls1955 commented Sep 28, 2024

Ah, didn't know such file exists. If we were to add an append file, mind if I open a PR for that?

@meatball133
Copy link
Member

Sure go ahead, sorry for being slow to respond.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants