Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: ready-to-show event on webContents #43531

Open
3 tasks done
nikwen opened this issue Sep 3, 2024 · 2 comments
Open
3 tasks done

[Feature Request]: ready-to-show event on webContents #43531

nikwen opened this issue Sep 3, 2024 · 2 comments

Comments

@nikwen
Copy link
Contributor

nikwen commented Sep 3, 2024

Preflight Checklist

Problem Description

I moved from BrowserWindow to a BaseWindow with one or more webContents (via WebContentsView). I'd like to know when each of the webContents are ready-to-show.

Proposed Solution

I propose this API:

webContents.on("ready-to-show", () => console.log("ready-to-show"));

Alternatives Considered

Additional Information

ready-to-show already seems to be available on webContents internally:

this.on('ready-to-show' as any, () => {

For some reason, the following doesn't work though:

webContents.on("ready-to-show", () => console.log("ready-to-show"));

The event also isn't documented.

@adityarawat007
Copy link

Hello @nikwen i would like to contribute to this project, can you please assign this issue to me?
Thankyou

@nikwen
Copy link
Contributor Author

nikwen commented Sep 8, 2024

Sounds great! I don't have permission to assign the issue, and you don't need to be assigned to work on it. Just open a pull request with your changes and someone will look at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants
@nikwen @adityarawat007 and others