Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Solaris VM test #3885

Draft
wants to merge 4 commits into
base: dev
Choose a base branch
from
Draft

add a Solaris VM test #3885

wants to merge 4 commits into from

Conversation

Cyan4973
Copy link
Contributor

to Github Actions CI

to Github Actions CI
write the recipe directly in the .yml file

For some reason, SolarisOS is not considered posix by the Makefile (?)
@Cyan4973
Copy link
Contributor Author

One issue with the cmake recipe is that it requires the CXX compiler to compile zstd.
This is incorrect. zstd itself doesn't require CXX, only C. This is a problem for systems which can provide a C compiler but not a C++ one, since the cmake recipe will fail them.
It also seems this over-reach has been used and depended upon in some parts of the complex multi-files cmake recipe. Consequently, removing CXX from the zstd project creates errors in some environments,
cmake + visual being one of them.
I guess fixing this is a preliminary step in order to allow Solaris VM as a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants