Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: flutter/flutter
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: flutter/flutter
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: flutter-3.27-candidate.0
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 58 files changed
  • 5 contributors

Commits on Oct 18, 2024

  1. Beta test alternate correct macOS framework xcprivacy manifest locati…

    …on (#157136)
    
    The PrivacyInfo.xcprivacy file was originally copied to the top-level macOS framework, but instead needs to be in the Resources directory (which is a different path than iOS).  This caused codesigning issues #157016.
    
    The path is being corrected flutter/engine#55938 so update the framework test to handle either path.  It will be updated to just check the correct path once it rolls into the framework.
    jmagman authored Oct 18, 2024
    Configuration menu
    Copy the full SHA
    077c008 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    2e2c358 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Flutter tool assumes impeller is enabled by default (#156540) (#156545)

    Cherry pick request to get correct analytics
    jtmcdole authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    1806f2c View commit details
    Browse the repository at this point in the history
  2. [CP-beta] Fix flavor-conditional asset bundling for path dependencies (

    …#157306)
    
    Fixes #155755 on the beta branch so that this will be available with the 3.27 release.
    
    <details>
    
    <summary> Pre-launch checklist </summary> 
    
    </details>
    andrewkolos authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    41f3f40 View commit details
    Browse the repository at this point in the history
  3. [CP-beta]Add handler for jlink error when using Java 21 (#157946)

    This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
    Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
    
    ### Issue Link:
    What is the link to the issue this cherry-pick is addressing?
    
    #156304
    
    ### Changelog Description:
    Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples
    
    Provides guidance on how to fix a common error encountered when using Java 21 and Android Gradle Plugin versions less than 8.2.1, a combination that many users are encountering due to a recent Android Studio upgrade.
    
    ### Impact Description:
    What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
    
    Flutter apps fail to build on Android when using the previously mentioned combination (Java 21/AGP < 8.2.1). This error handler guides users on fixing the problem.
    
    ### Workaround:
    Is there a workaround for this issue?
    
    Users can upgrade their AGP version, or specify a lower Java version. But they would be unlikely to know this, because the (unhandled) error message is not helpful for Flutter developers.
    
    ### Risk:
    What is the risk level of this cherry-pick?
    
    ### Test Coverage:
    Are you confident that your fix is well-tested by automated tests?
    
    ### Validation Steps:
    What are the steps to validate that this fix works?
    
    Try building an app with the mentioned combination, verify that the handler triggers (i.e., the message includes `flutter fix...`
    flutteractionsbot authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    831ae93 View commit details
    Browse the repository at this point in the history
  4. [CP-beta]Support host android apps with kts gradle files for add to…

    … app (#157881)
    
    This pull request is created by [automatic cherry pick workflow](https://github.com/flutter/flutter/blob/main/docs/releases/Flutter-Cherrypick-Process.md#automatically-creates-a-cherry-pick-request)
    Please fill in the form below, and a flutter domain expert will evaluate this cherry pick request.
    
    ### Issue Link:
    What is the link to the issue this cherry-pick is addressing?
    
    This allows host Android apps using Kotlin Gradle files to depend on a Flutter module as source, see
    https://docs.flutter.dev/add-to-app/android/project-setup#add-the-flutter-module-as-a-dependency. 
    
    Previously they wouldn't be able to, because we expected the host app to use `setBinding` in it's Gradle files, which is Groovy syntax that doesn't have a parallel in the Kotlin Gradle DSL. They could still depend on a flutter module if built as an aar.
    
    ### Changelog Description:
    Explain this cherry pick in one line that is accessible to most Flutter developers. See [best practices](https://github.com/flutter/flutter/blob/main/docs/releases/Hotfix-Documentation-Best-Practices.md) for examples
    
    Allows host Android apps using Kotlin Gradle files to include a Flutter module.
    
    ### Impact Description:
    What is the impact (ex. visual jank on Samsung phones, app crash, cannot ship an iOS app)? Does it impact development (ex. flutter doctor crashes when Android Studio is installed), or the shipping production app (the app crashes on launch)
    
    Without this change, Android apps using Kotlin Gradle files are unable to depend on a Flutter module as source (they would still be able to as an aar).
    
    ### Workaround:
    Is there a workaround for this issue?
    
    Build the flutter module as an aar.
    
    ### Risk:
    What is the risk level of this cherry-pick?
    
    ### Test Coverage:
    Are you confident that your fix is well-tested by automated tests?
    
    ### Validation Steps:
    What are the steps to validate that this fix works?
    
    Create a new Android app (probably in Android studio).
    Create a Flutter module (`flutter create foobar --template=module`).
    Apply [this diff](1f1e92a), matching names to your specific case, to the Android app.
    flutteractionsbot authored Nov 5, 2024
    Configuration menu
    Copy the full SHA
    31c0ff4 View commit details
    Browse the repository at this point in the history
Loading