Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: geoschem/gcpy
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.4.0
Choose a base ref
...
head repository: geoschem/gcpy
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.4.1
Choose a head ref
  • 5 commits
  • 5 files changed
  • 1 contributor

Commits on Dec 7, 2023

  1. Bug fix: Use proper default value for weightsdir in file_regrid.py

    This commit fixes the bug described in #278.
    
    gcpy/file_regrid.py
    - Change the default value for weightsdir from False to "." where
      command line arguments are parsed.  This will prevent a TypeError.
      This bug was likely caused by a cut-n-paste error.
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    23486a7 View commit details
    Browse the repository at this point in the history
  2. Now use "." instead of "" for default --weightsdir value

    gcpy/file_regrid.py
    - Now use "." as the default value for --weightsdir, which will save
      regridding weights to the current directory.
    
    CHANGELOG.md
    - Updated accordingly
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Dec 7, 2023
    Configuration menu
    Copy the full SHA
    3b92614 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2023

  1. Merge PR #279 (Use proper default for weightsdir in file_regrid.py )

    This merge brings PR #279 (Bug fix: Use proper default value for
    weightsdir in file_regrid.py, by @yantosca) into the GCPy 1.4.1
    development stream.
    
    This PR fixes an issue (i.e. incorrect type of default variable resulting
    in a TypeError) when calling file_regrid.py without specifying a value for
    the --weightsdir command line argument.
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    9ab1a2d View commit details
    Browse the repository at this point in the history
  2. Update version numbers for GCPy 1.4.1 release

    CHANGELOG.md
    docs/source/conf.py
    gcpy/_version.py
    - Changed version numbers
    
    setup.py
    - Removed, this is for distributinog on PyPi (which we no longer do)
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a6f3684 View commit details
    Browse the repository at this point in the history
  3. GCPy 1.4.1 release

    This is the official release commit for GCPy 1.4.1.
    
    This is a bugfix release that fixes the issue that was described in
    issue #278.  This was resolved with PR #279.
    
    Signed-off-by: Bob Yantosca <yantosca@seas.harvard.edu>
    yantosca committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    a056352 View commit details
    Browse the repository at this point in the history
Loading